[python-committers] Requesting reviews

[Paul Moore]

Hmm, as an example, #2858, which seems to be about the AST (which I'm
not familiar with). I don't particularly want to single this out as a
problem, but it's an example of the sort of request that confuses me -
I simply don't know what help I can offer. Maybe there is some
suspicion that there might be a Windows element - but without some
guidance, I'm not sure where to look.

Paul

On 6 October 2017 at 16:38, Zachary Ware <zachary.ware+pydev at gmail.com> wrote:
> On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore <p.f.moore at gmail.com> wrote:
>> I'm seeing a lot of review requests from github, asking for reviews
>> from the Windows team. Many of the PRs don't as far as I can see have
>> much Windows-specific about them. It doesn't bother me too much (I
>> just ignore ones I don't have anything to say on) but I thought the
>> idea of having the teams was to ask for specific experts to take a
>> look when needed?
>>
>> As I say, it's not a big deal for me, but I'm curious how others think
>> the review teams should be used.
>
> Do you have some examples of superfluous requests?  I don't think I've
> seen any, other than a rash of bad drive-by PRs that merge a
> maintenance branch into master, which GitHub should be working on
> preventing.  See https://github.com/python/core-workflow/issues/168
> for more on that.
>
> --
> Zach
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/