[python-committers] Accept a PR but only push it once tests pass?

Victor Stinner victor.stinner at gmail.com
Tue Feb 14 12:56:24 EST 2017


2017-02-14 18:38 GMT+01:00 Brett Cannon <brett at python.org>:
> The reason I didn't turn that on to begin with was I wanted to wait until we
> had proven to ourselves that our test suite was stable enough to not block
> PRs on a regular basis due to some flaky test. If people feel the tests are
> passing consistently when they should then I'm all for flipping on this
> protection.

Oh ok, I see. Let's say that we wait one month to see how things are
going before changing the process ;-)

Hopefully the Travis CI jobs are currently quite fast: less than 10
minutes, whereas many buildbots take longer than 1 hour! (up to 5
hours in the worst cases)

Victor


More information about the python-committers mailing list