[Python-checkins] gh-102251: Fix reference leak in _testsinglephase initialization (#105082)
erlend-aasland
webhook-mailer at python.org
Tue May 30 05:28:21 EDT 2023
https://github.com/python/cpython/commit/d14eb3433cf2a40a202471b815f0a935f2840ead
commit: d14eb3433cf2a40a202471b815f0a935f2840ead
branch: main
author: sunmy2019 <59365878+sunmy2019 at users.noreply.github.com>
committer: erlend-aasland <erlend.aasland at protonmail.com>
date: 2023-05-30T09:27:55Z
summary:
gh-102251: Fix reference leak in _testsinglephase initialization (#105082)
Correctly decref 'initialized' in init_module()
Co-authored-by: Erlend E. Aasland <erlend.aasland at protonmail.com>
files:
M Modules/_testsinglephase.c
diff --git a/Modules/_testsinglephase.c b/Modules/_testsinglephase.c
index a16157702ae7..8e6973f0b052 100644
--- a/Modules/_testsinglephase.c
+++ b/Modules/_testsinglephase.c
@@ -140,7 +140,9 @@ init_module(PyObject *module, module_state *state)
if (initialized == NULL) {
return -1;
}
- if (PyModule_AddObjectRef(module, "_module_initialized", initialized) != 0) {
+ int rc = PyModule_AddObjectRef(module, "_module_initialized", initialized);
+ Py_DECREF(initialized);
+ if (rc < 0) {
return -1;
}
More information about the Python-checkins
mailing list