[Python-checkins] gh-74690: Make a typing test more resilient (#104691)

JelleZijlstra webhook-mailer at python.org
Sat May 20 20:13:44 EDT 2023


https://github.com/python/cpython/commit/b870b1fa755808977578e99bd42859c519e00bb7
commit: b870b1fa755808977578e99bd42859c519e00bb7
branch: main
author: Alex Waygood <Alex.Waygood at Gmail.com>
committer: JelleZijlstra <jelle.zijlstra at gmail.com>
date: 2023-05-20T17:13:37-07:00
summary:

gh-74690: Make a typing test more resilient (#104691)

files:
M Lib/test/test_typing.py

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 6459fa3eb96a..9a3e64289ee8 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -3154,10 +3154,10 @@ class NonP(P):
 
         class NonPR(PR): pass
 
-        class C:
+        class C(metaclass=abc.ABCMeta):
             x = 1
 
-        class D:
+        class D(metaclass=abc.ABCMeta):
             def meth(self): pass
 
         self.assertNotIsInstance(C(), NonP)
@@ -3174,8 +3174,7 @@ def meth(self): pass
 
         acceptable_extra_attrs = {
             '_is_protocol', '_is_runtime_protocol', '__parameters__',
-            '__subclasshook__', '__abstractmethods__', '_abc_impl',
-            '__init__', '__annotations__',
+            '__init__', '__annotations__', '__subclasshook__',
         }
         self.assertLessEqual(vars(NonP).keys(), vars(C).keys() | acceptable_extra_attrs)
         self.assertLessEqual(



More information about the Python-checkins mailing list