[Python-checkins] [3.11] gh-48241: Clarify URL needs to be encoded when provided to urlopen and Request (GH-103855) (#103891)
erlend-aasland
webhook-mailer at python.org
Tue May 9 18:22:13 EDT 2023
https://github.com/python/cpython/commit/2fa14d47af1a2f4a7edbec10c9cf6f21a695ffda
commit: 2fa14d47af1a2f4a7edbec10c9cf6f21a695ffda
branch: 3.11
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: erlend-aasland <erlend.aasland at protonmail.com>
date: 2023-05-10T00:22:06+02:00
summary:
[3.11] gh-48241: Clarify URL needs to be encoded when provided to urlopen and Request (GH-103855) (#103891)
(cherry picked from commit 44010d0f1203134cd8f885ca574caaef373e80f6)
Co-authored-by: Michael Blahay <mblahay at users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz at langa.pl>
files:
A Misc/NEWS.d/next/Documentation/2023-04-25-22-58-08.gh-issue-48241.l1Gxxh.rst
M Doc/library/urllib.request.rst
diff --git a/Doc/library/urllib.request.rst b/Doc/library/urllib.request.rst
index 64cc9c388ec3..1b05458280d8 100644
--- a/Doc/library/urllib.request.rst
+++ b/Doc/library/urllib.request.rst
@@ -28,8 +28,8 @@ The :mod:`urllib.request` module defines the following functions:
.. function:: urlopen(url, data=None[, timeout], *, cafile=None, capath=None, cadefault=False, context=None)
- Open the URL *url*, which can be either a string or a
- :class:`Request` object.
+ Open *url*, which can be either a string containing a valid, properly
+ encoded URL, or a :class:`Request` object.
*data* must be an object specifying additional data to be sent to the
server, or ``None`` if no such data is needed. See :class:`Request`
@@ -192,7 +192,7 @@ The following classes are provided:
This class is an abstraction of a URL request.
- *url* should be a string containing a valid URL.
+ *url* should be a string containing a valid, properly encoded URL.
*data* must be an object specifying additional data to send to the
server, or ``None`` if no such data is needed. Currently HTTP
diff --git a/Misc/NEWS.d/next/Documentation/2023-04-25-22-58-08.gh-issue-48241.l1Gxxh.rst b/Misc/NEWS.d/next/Documentation/2023-04-25-22-58-08.gh-issue-48241.l1Gxxh.rst
new file mode 100644
index 000000000000..619505cf6ee5
--- /dev/null
+++ b/Misc/NEWS.d/next/Documentation/2023-04-25-22-58-08.gh-issue-48241.l1Gxxh.rst
@@ -0,0 +1 @@
+Clarifying documentation about the url parameter to urllib.request.urlopen and urllib.request.Requst needing to be encoded properly.
More information about the Python-checkins
mailing list