[Python-checkins] gh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (#102445)
AlexWaygood
webhook-mailer at python.org
Sun Mar 5 16:38:08 EST 2023
https://github.com/python/cpython/commit/96e10229292145012bc462a6ab3ce1626c8acf71
commit: 96e10229292145012bc462a6ab3ce1626c8acf71
branch: main
author: Alex Waygood <Alex.Waygood at Gmail.com>
committer: AlexWaygood <Alex.Waygood at Gmail.com>
date: 2023-03-05T21:37:29Z
summary:
gh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (#102445)
files:
M Lib/test/test_typing.py
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 2eeaf91d78d8..0483ca3aa42f 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -473,7 +473,6 @@ def test_var_substitution(self):
def test_bad_var_substitution(self):
T = TypeVar('T')
- P = ParamSpec("P")
bad_args = (
(), (int, str), Union,
Generic, Generic[T], Protocol, Protocol[T],
@@ -1037,8 +1036,6 @@ class G2(Generic[Unpack[Ts]]): pass
def test_repr_is_correct(self):
Ts = TypeVarTuple('Ts')
- T = TypeVar('T')
- T2 = TypeVar('T2')
class G1(Generic[*Ts]): pass
class G2(Generic[Unpack[Ts]]): pass
@@ -1307,7 +1304,7 @@ def test_callable_args_are_correct(self):
i = Callable[[None], *Ts]
j = Callable[[None], Unpack[Ts]]
self.assertEqual(i.__args__, (type(None), *Ts))
- self.assertEqual(i.__args__, (type(None), Unpack[Ts]))
+ self.assertEqual(j.__args__, (type(None), Unpack[Ts]))
k = Callable[[None], tuple[int, *Ts]]
l = Callable[[None], Tuple[int, Unpack[Ts]]]
@@ -1435,8 +1432,6 @@ def g(*args: *Ts): pass
self.assertEqual(g.__annotations__, {'args': (*Ts,)[0]})
def test_variadic_args_with_ellipsis_annotations_are_correct(self):
- Ts = TypeVarTuple('Ts')
-
def a(*args: *tuple[int, ...]): pass
self.assertEqual(a.__annotations__,
{'args': (*tuple[int, ...],)[0]})
@@ -4918,7 +4913,6 @@ def test_overload_registry_repeated(self):
# Definitions needed for features introduced in Python 3.6
from test import ann_module, ann_module2, ann_module3, ann_module5, ann_module6
-import asyncio
T_a = TypeVar('T_a')
@@ -7077,16 +7071,6 @@ class C:
self.assertEqual(get_type_hints(C, globals())['classvar'], ClassVar[int])
self.assertEqual(get_type_hints(C, globals())['const'], Final[int])
- def test_hash_eq(self):
- self.assertEqual(len({Annotated[int, 4, 5], Annotated[int, 4, 5]}), 1)
- self.assertNotEqual(Annotated[int, 4, 5], Annotated[int, 5, 4])
- self.assertNotEqual(Annotated[int, 4, 5], Annotated[str, 4, 5])
- self.assertNotEqual(Annotated[int, 4], Annotated[int, 4, 4])
- self.assertEqual(
- {Annotated[int, 4, 5], Annotated[int, 4, 5], Annotated[T, 4, 5]},
- {Annotated[int, 4, 5], Annotated[T, 4, 5]}
- )
-
def test_cannot_subclass(self):
with self.assertRaisesRegex(TypeError, "Cannot subclass .*Annotated"):
class C(Annotated):
@@ -7515,7 +7499,6 @@ class Y(Generic[P, T]):
self.assertEqual(B.__args__, ((int, str,), Tuple[bytes, float]))
def test_var_substitution(self):
- T = TypeVar("T")
P = ParamSpec("P")
subst = P.__typing_subst__
self.assertEqual(subst((int, str)), (int, str))
@@ -7835,7 +7818,7 @@ def test_special_attrs2(self):
self.assertEqual(fr.__module__, 'typing')
# Forward refs are currently unpicklable.
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
- with self.assertRaises(TypeError) as exc:
+ with self.assertRaises(TypeError):
pickle.dumps(fr, proto)
self.assertEqual(SpecialAttrsTests.TypeName.__name__, 'TypeName')
More information about the Python-checkins
mailing list