[Python-checkins] Fix unused classes in a typing test (GH-102437)
miss-islington
webhook-mailer at python.org
Sun Mar 5 10:31:49 EST 2023
https://github.com/python/cpython/commit/c957128b480445079b462b23b5ba3162c032f098
commit: c957128b480445079b462b23b5ba3162c032f098
branch: 3.11
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2023-03-05T07:31:42-08:00
summary:
Fix unused classes in a typing test (GH-102437)
As part of investigation issue https://github.com/python/cpython/issues/102433, I discovered what I believe to be an error where two classes `CI` and `DI` are not being used. The assertions beneath them act on `C` and `D`, duplicating existing assertions in this test.
(cherry picked from commit 7894bbe94ba319eb650f383cb5196424c77b2cfd)
Co-authored-by: JosephSBoyle <48555120+JosephSBoyle at users.noreply.github.com>
Automerge-Triggered-By: GH:AlexWaygood
files:
M Lib/test/test_typing.py
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 276f95bacfcf..4fe17a655dfd 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -2916,8 +2916,8 @@ class DI:
def __init__(self):
self.x = None
- self.assertIsInstance(C(), P)
- self.assertIsInstance(D(), P)
+ self.assertIsInstance(CI(), P)
+ self.assertIsInstance(DI(), P)
def test_protocols_in_unions(self):
class P(Protocol):
More information about the Python-checkins
mailing list