[Python-checkins] gh-105436: Ignore unrelated errors when checking empty env (GH-105742)
zooba
webhook-mailer at python.org
Tue Jun 13 19:00:22 EDT 2023
https://github.com/python/cpython/commit/4cefe3cf10f498c0927ae4fdba4880d5a64826e4
commit: 4cefe3cf10f498c0927ae4fdba4880d5a64826e4
branch: main
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2023-06-14T00:00:16+01:00
summary:
gh-105436: Ignore unrelated errors when checking empty env (GH-105742)
files:
M Lib/test/test_subprocess.py
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 3d4fffbb8e79..817eab0c8a7e 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -1695,9 +1695,10 @@ def test_run_with_pathlike_path_and_arguments(self):
@unittest.skipUnless(mswindows, "Maybe test trigger a leak on Ubuntu")
def test_run_with_an_empty_env(self):
# gh-105436: fix subprocess.run(..., env={}) broken on Windows
- args = [sys.executable, "-c", 'import sys; sys.exit(57)']
- res = subprocess.run(args, env={})
- self.assertEqual(res.returncode, 57)
+ args = [sys.executable, "-c", 'pass']
+ # Ignore subprocess errors - we only care that the API doesn't
+ # raise an OSError
+ subprocess.run(args, env={})
def test_capture_output(self):
cp = self.run_python(("import sys;"
More information about the Python-checkins
mailing list