[Python-checkins] gh-75371: reformat Makefile.pre.in to accommodate for empty FRAMEWORKALTINSTALLLAST (#107035)

ambv webhook-mailer at python.org
Sat Jul 22 11:59:14 EDT 2023


https://github.com/python/cpython/commit/9c38206925246ab919cf558ac069ae9458720ba7
commit: 9c38206925246ab919cf558ac069ae9458720ba7
branch: main
author: Moritz Neeb <nt4u at kpvn.de>
committer: ambv <lukasz at langa.pl>
date: 2023-07-22T17:59:11+02:00
summary:

gh-75371: reformat Makefile.pre.in to accommodate for empty FRAMEWORKALTINSTALLLAST (#107035)

in the case of an empty FRAMEWORKALTINSTALLLAST, this patch prevents leaving
an astray linebreak and two tabs in the resulting Makefile.

Before change:
```
.PHONY: commoninstall
commoninstall:  check-clean-src  \
		altbininstall libinstall inclinstall libainstall \
		sharedinstall altmaninstall \

```

After change (with empty FRAMEWORKALTINSTALLLAST):
```
.PHONY: commoninstall
commoninstall:  check-clean-src  \
		altbininstall libinstall inclinstall libainstall \
		sharedinstall altmaninstall
```

files:
M Makefile.pre.in

diff --git a/Makefile.pre.in b/Makefile.pre.in
index a4f76eaaaba52..3725feaca66ce 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -1940,8 +1940,7 @@ altinstall: commoninstall
 .PHONY: commoninstall
 commoninstall:  check-clean-src @FRAMEWORKALTINSTALLFIRST@ \
 		altbininstall libinstall inclinstall libainstall \
-		sharedinstall altmaninstall \
-		@FRAMEWORKALTINSTALLLAST@
+		sharedinstall altmaninstall @FRAMEWORKALTINSTALLLAST@
 
 # Install shared libraries enabled by Setup
 DESTDIRS=	$(exec_prefix) $(LIBDIR) $(BINLIBDEST) $(DESTSHARED)



More information about the Python-checkins mailing list