[Python-checkins] Add more recipe tests. Make the factor recipe a bit faster and clearer. (GH-106817)

rhettinger webhook-mailer at python.org
Sun Jul 16 22:37:10 EDT 2023


https://github.com/python/cpython/commit/babb22da5a25c18a2d203bf72ba35e7861ca60ee
commit: babb22da5a25c18a2d203bf72ba35e7861ca60ee
branch: main
author: Raymond Hettinger <rhettinger at users.noreply.github.com>
committer: rhettinger <rhettinger at users.noreply.github.com>
date: 2023-07-16T21:37:07-05:00
summary:

Add more recipe tests. Make the factor recipe a bit faster and clearer. (GH-106817)

files:
M Doc/library/itertools.rst

diff --git a/Doc/library/itertools.rst b/Doc/library/itertools.rst
index f88525456ff93..730736bbb59ed 100644
--- a/Doc/library/itertools.rst
+++ b/Doc/library/itertools.rst
@@ -1049,11 +1049,10 @@ The following recipes have a more mathematical flavor:
        # factor(1_000_000_000_000_403) --> 1000000000000403
        for prime in sieve(math.isqrt(n) + 1):
            while True:
-               quotient, remainder = divmod(n, prime)
-               if remainder:
+               if n % prime:
                    break
                yield prime
-               n = quotient
+               n //= prime
                if n == 1:
                    return
        if n > 1:
@@ -1354,6 +1353,12 @@ The following recipes have a more mathematical flavor:
     >>> set(sieve(10_000)).isdisjoint(carmichael)
     True
 
+    >>> list(factor(99))                    # Code example 1
+    [3, 3, 11]
+    >>> list(factor(1_000_000_000_000_007)) # Code example 2
+    [47, 59, 360620266859]
+    >>> list(factor(1_000_000_000_000_403)) # Code example 3
+    [1000000000000403]
     >>> list(factor(0))
     []
     >>> list(factor(1))



More information about the Python-checkins mailing list