[Python-checkins] [3.12] gh-106368: Increase Argument Clinic test coverage (GH-106389) (#106390)

erlend-aasland webhook-mailer at python.org
Mon Jul 3 20:26:48 EDT 2023


https://github.com/python/cpython/commit/b84365fe3eaa52bac8ffa7369ad0496a807aa8a7
commit: b84365fe3eaa52bac8ffa7369ad0496a807aa8a7
branch: 3.12
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: erlend-aasland <erlend.aasland at protonmail.com>
date: 2023-07-04T00:26:44Z
summary:

[3.12] gh-106368: Increase Argument Clinic test coverage (GH-106389) (#106390)

Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash
(cherry picked from commit 3406f8cce542ea4edf4153c0fac5216df283a9b1)

Co-authored-by: Erlend E. Aasland <erlend at python.org>

files:
M Lib/test/test_clinic.py

diff --git a/Lib/test/test_clinic.py b/Lib/test/test_clinic.py
index c5cfe53e0df99..03754d0bf123b 100644
--- a/Lib/test/test_clinic.py
+++ b/Lib/test/test_clinic.py
@@ -730,6 +730,18 @@ def test_disallowed_grouping__empty_group_on_right(self):
         )
         self.assertIn(msg, out)
 
+    def test_disallowed_grouping__no_matching_bracket(self):
+        out = self.parse_function_should_fail("""
+            module foo
+            foo.empty_group
+                param: int
+                ]
+                group2: int
+                ]
+        """)
+        msg = "Function empty_group has a ] without a matching [."
+        self.assertIn(msg, out)
+
     def test_no_parameters(self):
         function = self.parse_function("""
             module foo
@@ -809,6 +821,18 @@ def test_single_slash(self):
         )
         self.assertIn(msg, out)
 
+    def test_double_slash(self):
+        out = self.parse_function_should_fail("""
+            module foo
+            foo.bar
+                a: int
+                /
+                b: int
+                /
+        """)
+        msg = "Function bar uses '/' more than once."
+        self.assertIn(msg, out)
+
     def test_mix_star_and_slash(self):
         out = self.parse_function_should_fail("""
             module foo



More information about the Python-checkins mailing list