[Python-checkins] gh-106368: Increase Argument Clinic test coverage (#106369)
erlend-aasland
webhook-mailer at python.org
Mon Jul 3 16:16:53 EDT 2023
https://github.com/python/cpython/commit/7f4c8121db62a9f72f00f2d9f73381e82f289581
commit: 7f4c8121db62a9f72f00f2d9f73381e82f289581
branch: main
author: Erlend E. Aasland <erlend at python.org>
committer: erlend-aasland <erlend.aasland at protonmail.com>
date: 2023-07-03T20:16:50Z
summary:
gh-106368: Increase Argument Clinic test coverage (#106369)
Add tests for 'self' and 'defining_class' converter requirements.
files:
M Lib/test/test_clinic.py
diff --git a/Lib/test/test_clinic.py b/Lib/test/test_clinic.py
index fab2d2bb0bdbe..51d2ac972752f 100644
--- a/Lib/test/test_clinic.py
+++ b/Lib/test/test_clinic.py
@@ -829,6 +829,63 @@ def test_kwarg_splats_disallowed_in_function_call_annotations(self):
out = self.parse_function_should_fail(fn)
self.assertEqual(out, expected_error_msg)
+ def test_self_param_placement(self):
+ expected_error_msg = (
+ "Error on line 0:\n"
+ "A 'self' parameter, if specified, must be the very first thing "
+ "in the parameter block.\n"
+ )
+ block = """
+ module foo
+ foo.func
+ a: int
+ self: self(type="PyObject *")
+ """
+ out = self.parse_function_should_fail(block)
+ self.assertEqual(out, expected_error_msg)
+
+ def test_self_param_cannot_be_optional(self):
+ expected_error_msg = (
+ "Error on line 0:\n"
+ "A 'self' parameter cannot be marked optional.\n"
+ )
+ block = """
+ module foo
+ foo.func
+ self: self(type="PyObject *") = None
+ """
+ out = self.parse_function_should_fail(block)
+ self.assertEqual(out, expected_error_msg)
+
+ def test_defining_class_param_placement(self):
+ expected_error_msg = (
+ "Error on line 0:\n"
+ "A 'defining_class' parameter, if specified, must either be the "
+ "first thing in the parameter block, or come just after 'self'.\n"
+ )
+ block = """
+ module foo
+ foo.func
+ self: self(type="PyObject *")
+ a: int
+ cls: defining_class
+ """
+ out = self.parse_function_should_fail(block)
+ self.assertEqual(out, expected_error_msg)
+
+ def test_defining_class_param_cannot_be_optional(self):
+ expected_error_msg = (
+ "Error on line 0:\n"
+ "A 'defining_class' parameter cannot be marked optional.\n"
+ )
+ block = """
+ module foo
+ foo.func
+ cls: defining_class(type="PyObject *") = None
+ """
+ out = self.parse_function_should_fail(block)
+ self.assertEqual(out, expected_error_msg)
+
def test_unused_param(self):
block = self.parse("""
module foo
More information about the Python-checkins
mailing list