[Python-checkins] gh-100931: Test all `pickle` protocols in `test_slice` (#100932)

AlexWaygood webhook-mailer at python.org
Wed Jan 11 04:44:00 EST 2023


https://github.com/python/cpython/commit/8795ad1bd0d6ee031543fcaf5a86a60b37950714
commit: 8795ad1bd0d6ee031543fcaf5a86a60b37950714
branch: main
author: Nikita Sobolev <mail at sobolevn.me>
committer: AlexWaygood <Alex.Waygood at Gmail.com>
date: 2023-01-11T09:43:45Z
summary:

gh-100931: Test all `pickle` protocols in `test_slice` (#100932)

files:
M Lib/test/test_json/test_attrdict.py
M Lib/test/test_slice.py

diff --git a/Lib/test/test_json/test_attrdict.py b/Lib/test/test_json/test_attrdict.py
index 48d14f4db93c..143ea462d310 100644
--- a/Lib/test/test_json/test_attrdict.py
+++ b/Lib/test/test_json/test_attrdict.py
@@ -133,7 +133,7 @@ def test_pickle(self):
         cached_module = sys.modules.get('json')
         sys.modules['json'] = self.json
         try:
-            for protocol in range(6):
+            for protocol in range(pickle.HIGHEST_PROTOCOL + 1):
                 kepler_ad2 = pickle.loads(pickle.dumps(kepler_ad, protocol))
                 self.assertEqual(kepler_ad2, kepler_ad)
                 self.assertEqual(type(kepler_ad2), AttrDict)
diff --git a/Lib/test/test_slice.py b/Lib/test/test_slice.py
index 4ae4142c60c8..c4bc8c82023d 100644
--- a/Lib/test/test_slice.py
+++ b/Lib/test/test_slice.py
@@ -235,8 +235,10 @@ def __setitem__(self, i, k):
         self.assertEqual(tmp, [(slice(1, 2), 42)])
 
     def test_pickle(self):
+        import pickle
+
         s = slice(10, 20, 3)
-        for protocol in (0,1,2):
+        for protocol in range(pickle.HIGHEST_PROTOCOL + 1):
             t = loads(dumps(s, protocol))
             self.assertEqual(s, t)
             self.assertEqual(s.indices(15), t.indices(15))



More information about the Python-checkins mailing list