[Python-checkins] gh-100882: Improve `test_pickling` case in `test_ast.py` (#100883)

pablogsal webhook-mailer at python.org
Mon Jan 9 14:20:32 EST 2023


https://github.com/python/cpython/commit/2e80c2a976c13dcb69a654b386164dca362295a3
commit: 2e80c2a976c13dcb69a654b386164dca362295a3
branch: main
author: Nikita Sobolev <mail at sobolevn.me>
committer: pablogsal <Pablogsal at gmail.com>
date: 2023-01-09T19:20:25Z
summary:

gh-100882: Improve `test_pickling` case in `test_ast.py` (#100883)

files:
M Lib/test/test_ast.py

diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py
index ab6a63faa590..53a6418329e5 100644
--- a/Lib/test/test_ast.py
+++ b/Lib/test/test_ast.py
@@ -639,18 +639,11 @@ def test_no_fields(self):
 
     def test_pickling(self):
         import pickle
-        mods = [pickle]
-        try:
-            import cPickle
-            mods.append(cPickle)
-        except ImportError:
-            pass
-        protocols = [0, 1, 2]
-        for mod in mods:
-            for protocol in protocols:
-                for ast in (compile(i, "?", "exec", 0x400) for i in exec_tests):
-                    ast2 = mod.loads(mod.dumps(ast, protocol))
-                    self.assertEqual(to_tuple(ast2), to_tuple(ast))
+
+        for protocol in range(pickle.HIGHEST_PROTOCOL + 1):
+            for ast in (compile(i, "?", "exec", 0x400) for i in exec_tests):
+                ast2 = pickle.loads(pickle.dumps(ast, protocol))
+                self.assertEqual(to_tuple(ast2), to_tuple(ast))
 
     def test_invalid_sum(self):
         pos = dict(lineno=2, col_offset=3)



More information about the Python-checkins mailing list