[Python-checkins] [3.11] gh-100776: Fix misleading default value in help(input) (GH-100788) (#100841)

hauntsaninja webhook-mailer at python.org
Sun Jan 8 04:23:18 EST 2023


https://github.com/python/cpython/commit/be7c19723fa3fea3a4efe5c9c795c1e4a2fc05f5
commit: be7c19723fa3fea3a4efe5c9c795c1e4a2fc05f5
branch: 3.11
author: Shantanu <12621235+hauntsaninja at users.noreply.github.com>
committer: hauntsaninja <12621235+hauntsaninja at users.noreply.github.com>
date: 2023-01-08T01:23:12-08:00
summary:

[3.11] gh-100776: Fix misleading default value in help(input) (GH-100788) (#100841)

(cherry picked from commit a2141882f259e21bb09fa0b7cba8142147b9e3d7)

Co-authored-by: Shantanu <12621235+hauntsaninja at users.noreply.github.com>

files:
A Misc/NEWS.d/next/Core and Builtins/2023-01-06-02-02-11.gh-issue-100776.pP8xux.rst
M Python/bltinmodule.c
M Python/clinic/bltinmodule.c.h

diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-01-06-02-02-11.gh-issue-100776.pP8xux.rst b/Misc/NEWS.d/next/Core and Builtins/2023-01-06-02-02-11.gh-issue-100776.pP8xux.rst
new file mode 100644
index 000000000000..b94121ea5f29
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2023-01-06-02-02-11.gh-issue-100776.pP8xux.rst	
@@ -0,0 +1 @@
+Fix misleading default value in :func:`input`'s ``__text_signature__``.
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index 94a7819c252e..a3fdb394a136 100644
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2065,7 +2065,7 @@ builtin_print_impl(PyObject *module, PyObject *args, PyObject *sep,
 /*[clinic input]
 input as builtin_input
 
-    prompt: object(c_default="NULL") = None
+    prompt: object(c_default="NULL") = ""
     /
 
 Read a string from standard input.  The trailing newline is stripped.
@@ -2079,7 +2079,7 @@ On *nix systems, readline is used if available.
 
 static PyObject *
 builtin_input_impl(PyObject *module, PyObject *prompt)
-/*[clinic end generated code: output=83db5a191e7a0d60 input=5e8bb70c2908fe3c]*/
+/*[clinic end generated code: output=83db5a191e7a0d60 input=159c46d4ae40977e]*/
 {
     PyThreadState *tstate = _PyThreadState_GET();
     PyObject *fin = _PySys_GetAttr(
diff --git a/Python/clinic/bltinmodule.c.h b/Python/clinic/bltinmodule.c.h
index 5d9a16a7b682..10cd6c820bcc 100644
--- a/Python/clinic/bltinmodule.c.h
+++ b/Python/clinic/bltinmodule.c.h
@@ -843,7 +843,7 @@ builtin_print(PyObject *module, PyObject *const *args, Py_ssize_t nargs, PyObjec
 }
 
 PyDoc_STRVAR(builtin_input__doc__,
-"input($module, prompt=None, /)\n"
+"input($module, prompt=\'\', /)\n"
 "--\n"
 "\n"
 "Read a string from standard input.  The trailing newline is stripped.\n"
@@ -1045,4 +1045,4 @@ builtin_issubclass(PyObject *module, PyObject *const *args, Py_ssize_t nargs)
 exit:
     return return_value;
 }
-/*[clinic end generated code: output=cc844ea007c1241f input=a9049054013a1b77]*/
+/*[clinic end generated code: output=c45d5fe414f7a8d7 input=a9049054013a1b77]*/



More information about the Python-checkins mailing list