[Python-checkins] gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100)

[corona10]

https://github.com/python/cpython/commit/0d4c7fcd4f078708a5ac6499af378ce5ee8eb211
commit: 0d4c7fcd4f078708a5ac6499af378ce5ee8eb211
branch: main
author: Vo Hoang Long <vohoanglong07 at gmail.com>
committer: corona10 <donghee.na92 at gmail.com>
date: 2023-02-22T00:14:41+09:00
summary:

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100)

Co-authored-by: Long Vo <long.vo at linecorp.com>

files:
A Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst
M Lib/test/test_urllib2.py
M Lib/urllib/error.py
M Misc/ACKS

diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index 498c0382d213..633d596ac3de 100644
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1827,6 +1827,7 @@ def test_HTTPError_interface(self):
     def test_gh_98778(self):
         x = urllib.error.HTTPError("url", 405, "METHOD NOT ALLOWED", None, None)
         self.assertEqual(getattr(x, "__notes__", ()), ())
+        self.assertIsInstance(x.fp.read(), bytes)
 
     def test_parse_proxy(self):
         parse_proxy_test_cases = [
diff --git a/Lib/urllib/error.py b/Lib/urllib/error.py
index feec0e7f848e..a9cd1ecadd63 100644
--- a/Lib/urllib/error.py
+++ b/Lib/urllib/error.py
@@ -43,7 +43,7 @@ def __init__(self, url, code, msg, hdrs, fp):
         self.fp = fp
         self.filename = url
         if fp is None:
-            fp = io.StringIO()
+            fp = io.BytesIO()
         self.__super_init(fp, hdrs, url, code)
 
     def __str__(self):
diff --git a/Misc/ACKS b/Misc/ACKS
index a9d4e453c7b5..ab19d69b0133 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1898,6 +1898,7 @@ Kurt Vile
 Norman Vine
 Pauli Virtanen
 Frank Visser
+Long Vo
 Johannes Vogel
 Michael Vogt
 Radu Voicilas
diff --git a/Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst b/Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst
new file mode 100644
index 000000000000..55841da44b11
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst
@@ -0,0 +1,2 @@
+The default value of ``fp`` becomes :class:`io.BytesIO` if :exc:`~urllib.error.HTTPError`
+is initialized without a designated ``fp`` parameter. Patch by Long Vo.