[Python-checkins] Make use of TESTFN_ASCII in test_fileio (GH-101645)
miss-islington
webhook-mailer at python.org
Tue Feb 7 12:23:05 EST 2023
https://github.com/python/cpython/commit/6fd5eb640af19b535f4f2ba27b1b61b8d17f02e9
commit: 6fd5eb640af19b535f4f2ba27b1b61b8d17f02e9
branch: main
author: Zachary Ware <zach at python.org>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2023-02-07T09:22:58-08:00
summary:
Make use of TESTFN_ASCII in test_fileio (GH-101645)
testBytesOpen requires an ASCII filename, but TESTFN usually isn't ASCII.
Automerge-Triggered-By: GH:zware
files:
M Lib/test/test_fileio.py
diff --git a/Lib/test/test_fileio.py b/Lib/test/test_fileio.py
index 2263604ed1f9..ebfcffd18291 100644
--- a/Lib/test/test_fileio.py
+++ b/Lib/test/test_fileio.py
@@ -12,7 +12,9 @@
from test.support import (
cpython_only, swap_attr, gc_collect, is_emscripten, is_wasi
)
-from test.support.os_helper import (TESTFN, TESTFN_UNICODE, make_bad_fd)
+from test.support.os_helper import (
+ TESTFN, TESTFN_ASCII, TESTFN_UNICODE, make_bad_fd,
+ )
from test.support.warnings_helper import check_warnings
from collections import UserList
@@ -431,18 +433,15 @@ def testUnicodeOpen(self):
def testBytesOpen(self):
# Opening a bytes filename
- try:
- fn = TESTFN.encode("ascii")
- except UnicodeEncodeError:
- self.skipTest('could not encode %r to ascii' % TESTFN)
+ fn = TESTFN_ASCII.encode("ascii")
f = self.FileIO(fn, "w")
try:
f.write(b"abc")
f.close()
- with open(TESTFN, "rb") as f:
+ with open(TESTFN_ASCII, "rb") as f:
self.assertEqual(f.read(), b"abc")
finally:
- os.unlink(TESTFN)
+ os.unlink(TESTFN_ASCII)
@unittest.skipIf(sys.getfilesystemencoding() != 'utf-8',
"test only works for utf-8 filesystems")
More information about the Python-checkins
mailing list