[Python-checkins] GH-98407: fix `test_kill_issue43884` to not leak child processes (#98491)

gvanrossum webhook-mailer at python.org
Mon Oct 24 13:50:41 EDT 2022


https://github.com/python/cpython/commit/3b2724abcfef7cbe5bf1717be1bb029e4c6b6600
commit: 3b2724abcfef7cbe5bf1717be1bb029e4c6b6600
branch: main
author: Kumar Aditya <59607654+kumaraditya303 at users.noreply.github.com>
committer: gvanrossum <gvanrossum at gmail.com>
date: 2022-10-24T10:50:35-07:00
summary:

GH-98407: fix `test_kill_issue43884` to not leak child processes  (#98491)

files:
M Lib/test/test_asyncio/test_subprocess.py

diff --git a/Lib/test/test_asyncio/test_subprocess.py b/Lib/test/test_asyncio/test_subprocess.py
index fe1d060c77d4..20bca3e6b727 100644
--- a/Lib/test/test_asyncio/test_subprocess.py
+++ b/Lib/test/test_asyncio/test_subprocess.py
@@ -184,7 +184,10 @@ def test_kill(self):
             self.assertEqual(-signal.SIGKILL, returncode)
 
     def test_kill_issue43884(self):
-        blocking_shell_command = f'{sys.executable} -c "import time; time.sleep(100000000)"'
+        if sys.platform == 'win32':
+            blocking_shell_command = f'{sys.executable} -c "import time; time.sleep(100000000)"'
+        else:
+            blocking_shell_command = 'sleep 1; sleep 1'
         creationflags = 0
         if sys.platform == 'win32':
             from subprocess import CREATE_NEW_PROCESS_GROUP



More information about the Python-checkins mailing list