[Python-checkins] gh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (#96610)

JelleZijlstra webhook-mailer at python.org
Thu Oct 6 08:16:37 EDT 2022


https://github.com/python/cpython/commit/e39ae6bef2c357a88e232dcab2e4b4c0f367544b
commit: e39ae6bef2c357a88e232dcab2e4b4c0f367544b
branch: main
author: Nikita Sobolev <mail at sobolevn.me>
committer: JelleZijlstra <jelle.zijlstra at gmail.com>
date: 2022-10-06T05:16:16-07:00
summary:

gh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (#96610)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra at gmail.com>

files:
M Lib/test/test_long.py

diff --git a/Lib/test/test_long.py b/Lib/test/test_long.py
index d092e0176c26..b6407b5a7c88 100644
--- a/Lib/test/test_long.py
+++ b/Lib/test/test_long.py
@@ -1518,6 +1518,22 @@ def __init__(self, value):
         self.assertEqual(i, 1)
         self.assertEqual(getattr(i, 'foo', 'none'), 'bar')
 
+        class ValidBytes:
+            def __bytes__(self):
+                return b'\x01'
+        class InvalidBytes:
+            def __bytes__(self):
+                return 'abc'
+        class MissingBytes: ...
+        class RaisingBytes:
+            def __bytes__(self):
+                1 / 0
+
+        self.assertEqual(int.from_bytes(ValidBytes()), 1)
+        self.assertRaises(TypeError, int.from_bytes, InvalidBytes())
+        self.assertRaises(TypeError, int.from_bytes, MissingBytes())
+        self.assertRaises(ZeroDivisionError, int.from_bytes, RaisingBytes())
+
     @support.cpython_only
     def test_from_bytes_small(self):
         # bpo-46361



More information about the Python-checkins mailing list