[Python-checkins] gh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (GH-97765)

miss-islington webhook-mailer at python.org
Mon Oct 3 17:39:49 EDT 2022


https://github.com/python/cpython/commit/a7e281150e9d4ad04f4b7276eb25870a0d37fbda
commit: a7e281150e9d4ad04f4b7276eb25870a0d37fbda
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2022-10-03T14:39:44-07:00
summary:

gh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (GH-97765)


Ensure that the event loop's `_thread_id` attribute and the asyncgen hooks set by `sys.set_asyncgen_hooks()` are always restored no matter where a KeyboardInterrupt exception is raised.
(cherry picked from commit 3a49dbb98ccc1b90554ed181386316efa38adfba)

Co-authored-by: hetmankp <728670+hetmankp at users.noreply.github.com>

files:
M Lib/asyncio/base_events.py

diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
index 1cc26ee7ccf0..23849852eb98 100644
--- a/Lib/asyncio/base_events.py
+++ b/Lib/asyncio/base_events.py
@@ -591,12 +591,13 @@ def run_forever(self):
         self._check_closed()
         self._check_running()
         self._set_coroutine_origin_tracking(self._debug)
-        self._thread_id = threading.get_ident()
 
         old_agen_hooks = sys.get_asyncgen_hooks()
-        sys.set_asyncgen_hooks(firstiter=self._asyncgen_firstiter_hook,
-                               finalizer=self._asyncgen_finalizer_hook)
         try:
+            self._thread_id = threading.get_ident()
+            sys.set_asyncgen_hooks(firstiter=self._asyncgen_firstiter_hook,
+                                   finalizer=self._asyncgen_finalizer_hook)
+
             events._set_running_loop(self)
             while True:
                 self._run_once()



More information about the Python-checkins mailing list