[Python-checkins] gh-87604: Clarify in docs that sys.addaudithook is not for sandboxes (GH-99372)

zooba webhook-mailer at python.org
Fri Nov 11 08:35:08 EST 2022


https://github.com/python/cpython/commit/c3c3871415c86088d45abcf73ccd2c2b09dc5772
commit: c3c3871415c86088d45abcf73ccd2c2b09dc5772
branch: main
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2022-11-11T13:35:02Z
summary:

gh-87604: Clarify in docs that sys.addaudithook is not for sandboxes (GH-99372)

files:
M Doc/library/sys.rst

diff --git a/Doc/library/sys.rst b/Doc/library/sys.rst
index f3fd16c4de75..d54ecd75a262 100644
--- a/Doc/library/sys.rst
+++ b/Doc/library/sys.rst
@@ -35,6 +35,15 @@ always available.
    can then log the event, raise an exception to abort the operation,
    or terminate the process entirely.
 
+   Note that audit hooks are primarily for collecting information about internal
+   or otherwise unobservable actions, whether by Python or libraries written in
+   Python. They are not suitable for implementing a "sandbox". In particular,
+   malicious code can trivially disable or bypass hooks added using this
+   function. At a minimum, any security-sensitive hooks must be added using the
+   C API :c:func:`PySys_AddAuditHook` before initialising the runtime, and any
+   modules allowing arbitrary memory modification (such as :mod:`ctypes`) should
+   be completely removed or closely monitored.
+
    .. audit-event:: sys.addaudithook "" sys.addaudithook
 
       Calling :func:`sys.addaudithook` will itself raise an auditing event



More information about the Python-checkins mailing list