[Python-checkins] gh-77560: Report possible errors in restoring builtins at finalization (GH-94255)

[serhiy-storchaka]

https://github.com/python/cpython/commit/bec802dbb87717a23acb9c600c15f40bc98340a3
commit: bec802dbb87717a23acb9c600c15f40bc98340a3
branch: main
author: Serhiy Storchaka <storchaka at gmail.com>
committer: serhiy-storchaka <storchaka at gmail.com>
date: 2022-06-25T19:02:09+03:00
summary:

gh-77560: Report possible errors in restoring builtins at finalization (GH-94255)

Seems in the past the copy of builtins was not made in some scenarios,
and the error was silenced. Write it now to stderr, so we have a chance
to see it.

files:
M Python/pylifecycle.c

diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index c2c9e90d05629..65e7f23e963b5 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -1462,7 +1462,7 @@ finalize_restore_builtins(PyThreadState *tstate)
     }
     PyDict_Clear(interp->builtins);
     if (PyDict_Update(interp->builtins, interp->builtins_copy)) {
-        _PyErr_Clear(tstate);
+        PyErr_WriteUnraisable(NULL);
     }
     Py_XDECREF(dict);
 }