[Python-checkins] gh-84461: Fix test_sqlite for Emscripten/WASI (#94125)

tiran webhook-mailer at python.org
Thu Jun 23 02:32:06 EDT 2022


https://github.com/python/cpython/commit/15bfabd1aabb0335f33202b28f96b4e4062b3bce
commit: 15bfabd1aabb0335f33202b28f96b4e4062b3bce
branch: main
author: Christian Heimes <christian at python.org>
committer: tiran <christian at python.org>
date: 2022-06-23T08:31:55+02:00
summary:

gh-84461: Fix test_sqlite for Emscripten/WASI (#94125)

files:
M Lib/test/test_sqlite3/test_dbapi.py

diff --git a/Lib/test/test_sqlite3/test_dbapi.py b/Lib/test/test_sqlite3/test_dbapi.py
index 18e84e9e58632..363a308f3e5fe 100644
--- a/Lib/test/test_sqlite3/test_dbapi.py
+++ b/Lib/test/test_sqlite3/test_dbapi.py
@@ -29,7 +29,10 @@
 import unittest
 import urllib.parse
 
-from test.support import SHORT_TIMEOUT, check_disallow_instantiation
+from test.support import (
+    SHORT_TIMEOUT, check_disallow_instantiation, requires_subprocess,
+    is_emscripten, is_wasi
+)
 from test.support import threading_helper
 from _testcapi import INT_MAX, ULLONG_MAX
 from os import SEEK_SET, SEEK_CUR, SEEK_END
@@ -653,6 +656,7 @@ def test_open_with_path_like_object(self):
 
     @unittest.skipIf(sys.platform == "win32", "skipped on Windows")
     @unittest.skipIf(sys.platform == "darwin", "skipped on macOS")
+    @unittest.skipIf(is_emscripten or is_wasi, "not supported on Emscripten/WASI")
     @unittest.skipUnless(TESTFN_UNDECODABLE, "only works if there are undecodable paths")
     def test_open_with_undecodable_path(self):
         path = TESTFN_UNDECODABLE
@@ -698,6 +702,7 @@ def test_open_uri_readonly(self):
 
     @unittest.skipIf(sys.platform == "win32", "skipped on Windows")
     @unittest.skipIf(sys.platform == "darwin", "skipped on macOS")
+    @unittest.skipIf(is_emscripten or is_wasi, "not supported on Emscripten/WASI")
     @unittest.skipUnless(TESTFN_UNDECODABLE, "only works if there are undecodable paths")
     def test_open_undecodable_uri(self):
         path = TESTFN_UNDECODABLE
@@ -1453,6 +1458,7 @@ def test_blob_closed_db_read(self):
                                    blob.read)
 
 
+ at threading_helper.requires_working_threading()
 class ThreadTests(unittest.TestCase):
     def setUp(self):
         self.con = sqlite.connect(":memory:")
@@ -1817,6 +1823,7 @@ def test_on_conflict_replace(self):
         self.assertEqual(self.cu.fetchall(), [('Very different data!', 'foo')])
 
 
+ at requires_subprocess()
 class MultiprocessTests(unittest.TestCase):
     CONNECTION_TIMEOUT = SHORT_TIMEOUT / 1000.  # Defaults to 30 ms
 



More information about the Python-checkins mailing list