[Python-checkins] gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails (GH-95264)

[serhiy-storchaka]

https://github.com/python/cpython/commit/b1f648efc56ff17e18ec2b7402d59a771b305004
commit: b1f648efc56ff17e18ec2b7402d59a771b305004
branch: main
author: Noam Cohen <noam at noam.me>
committer: serhiy-storchaka <storchaka at gmail.com>
date: 2022-07-26T14:34:15+03:00
summary:

gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails (GH-95264)

files:
M Modules/syslogmodule.c

diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c
index 27b176aeb6dba..c409fe968f889 100644
--- a/Modules/syslogmodule.c
+++ b/Modules/syslogmodule.c
@@ -191,8 +191,14 @@ syslog_syslog(PyObject * self, PyObject * args)
          */
         if ((openargs = PyTuple_New(0))) {
             PyObject *openlog_ret = syslog_openlog(self, openargs, NULL);
-            Py_XDECREF(openlog_ret);
             Py_DECREF(openargs);
+            if (openlog_ret == NULL) {
+                return NULL;
+            }
+            Py_DECREF(openlog_ret);
+        }
+        else {
+            return NULL;
         }
     }