[Python-checkins] gh-95105: Return Iterator from wsgiref.types.InputStream.__iter__ (#95106)

JelleZijlstra webhook-mailer at python.org
Thu Jul 21 16:26:09 EDT 2022


https://github.com/python/cpython/commit/b4378948a066821ce5147940ce3c1a80bc018b3c
commit: b4378948a066821ce5147940ce3c1a80bc018b3c
branch: main
author: Shantanu <12621235+hauntsaninja at users.noreply.github.com>
committer: JelleZijlstra <jelle.zijlstra at gmail.com>
date: 2022-07-21T13:26:04-07:00
summary:

gh-95105: Return Iterator from wsgiref.types.InputStream.__iter__ (#95106)

files:
A Misc/NEWS.d/next/Library/2022-07-21-19-55-49.gh-issue-95105.BIX2Km.rst
M Lib/wsgiref/types.py

diff --git a/Lib/wsgiref/types.py b/Lib/wsgiref/types.py
index 9e74a6c7312b1..ef0aead5b28b6 100644
--- a/Lib/wsgiref/types.py
+++ b/Lib/wsgiref/types.py
@@ -1,6 +1,6 @@
 """WSGI-related types for static type checking"""
 
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterable, Iterator
 from types import TracebackType
 from typing import Any, Protocol, TypeAlias
 
@@ -35,7 +35,7 @@ class InputStream(Protocol):
     def read(self, size: int = ..., /) -> bytes: ...
     def readline(self, size: int = ..., /) -> bytes: ...
     def readlines(self, hint: int = ..., /) -> list[bytes]: ...
-    def __iter__(self) -> Iterable[bytes]: ...
+    def __iter__(self) -> Iterator[bytes]: ...
 
 class ErrorStream(Protocol):
     """WSGI error stream as defined in PEP 3333"""
diff --git a/Misc/NEWS.d/next/Library/2022-07-21-19-55-49.gh-issue-95105.BIX2Km.rst b/Misc/NEWS.d/next/Library/2022-07-21-19-55-49.gh-issue-95105.BIX2Km.rst
new file mode 100644
index 0000000000000..58af62b1edc87
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-07-21-19-55-49.gh-issue-95105.BIX2Km.rst
@@ -0,0 +1 @@
+:meth:`wsgiref.types.InputStream.__iter__` should return ``Iterator[bytes]``, not ``Iterable[bytes]``. Patch by Shantanu Jain.



More information about the Python-checkins mailing list