[Python-checkins] gh-90355: Add isolated flag if currently isolated (GH-92857)

ambv webhook-mailer at python.org
Tue Jul 5 11:24:04 EDT 2022


https://github.com/python/cpython/commit/c8556bcf6c0b05ac46bd74880626a2853e7c99a1
commit: c8556bcf6c0b05ac46bd74880626a2853e7c99a1
branch: main
author: Carter Dodd <carter.dodd at gmail.com>
committer: ambv <lukasz at langa.pl>
date: 2022-07-05T17:23:44+02:00
summary:

gh-90355: Add isolated flag if currently isolated (GH-92857)

Co-authored-by: Éric <merwok at netwok.org>
Co-authored-by: Łukasz Langa <lukasz at langa.pl>

files:
A Misc/NEWS.d/next/Library/2022-01-03-15-07-06.bpo-46197.Z0djv6.rst
M Lib/ensurepip/__init__.py

diff --git a/Lib/ensurepip/__init__.py b/Lib/ensurepip/__init__.py
index a198a86e1f9af..1f25825f3febf 100644
--- a/Lib/ensurepip/__init__.py
+++ b/Lib/ensurepip/__init__.py
@@ -89,8 +89,18 @@ def _run_pip(args, additional_paths=None):
 sys.argv[1:] = {args}
 runpy.run_module("pip", run_name="__main__", alter_sys=True)
 """
-    return subprocess.run([sys.executable, '-W', 'ignore::DeprecationWarning',
-                           "-c", code], check=True).returncode
+
+    cmd = [
+        sys.executable,
+        '-W',
+        'ignore::DeprecationWarning',
+        '-c',
+        code,
+    ]
+    if sys.flags.isolated:
+        # run code in isolated mode if currently running isolated
+        cmd.insert(1, '-I')
+    return subprocess.run(cmd, check=True).returncode
 
 
 def version():
diff --git a/Misc/NEWS.d/next/Library/2022-01-03-15-07-06.bpo-46197.Z0djv6.rst b/Misc/NEWS.d/next/Library/2022-01-03-15-07-06.bpo-46197.Z0djv6.rst
new file mode 100644
index 0000000000000..7a3b2d59dfaf4
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-01-03-15-07-06.bpo-46197.Z0djv6.rst
@@ -0,0 +1 @@
+Fix :mod:`ensurepip` environment isolation for subprocess running ``pip``.



More information about the Python-checkins mailing list