[Python-checkins] bpo-46347: Fix memory leak in PyEval_EvalCodeEx. (GH-30546)
miss-islington
webhook-mailer at python.org
Tue Jan 11 18:09:26 EST 2022
https://github.com/python/cpython/commit/b1a94f1fab7c0aee0705483616a1b2c3f2713c00
commit: b1a94f1fab7c0aee0705483616a1b2c3f2713c00
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2022-01-11T15:09:22-08:00
summary:
bpo-46347: Fix memory leak in PyEval_EvalCodeEx. (GH-30546)
First introduced in 0332e569c12d3dc97171546c6dc10e42c27de34b
(cherry picked from commit 607d8a838f29ad3c4c4e85b39f338dade5f9cafe)
Co-authored-by: Yury Selivanov <yury at edgedb.com>
files:
A Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst
M Python/ceval.c
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst b/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst
new file mode 100644
index 0000000000000..fc12d6ba146ca
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst
@@ -0,0 +1 @@
+Fix memory leak in PyEval_EvalCodeEx.
diff --git a/Python/ceval.c b/Python/ceval.c
index 8ad1713b78c01..e906076e27e56 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -5132,16 +5132,9 @@ PyEval_EvalCodeEx(PyObject *_co, PyObject *globals, PyObject *locals,
}
allargs = newargs;
}
- PyObject **kwargs = PyMem_Malloc(sizeof(PyObject *)*kwcount);
- if (kwargs == NULL) {
- res = NULL;
- Py_DECREF(kwnames);
- goto fail;
- }
for (int i = 0; i < kwcount; i++) {
Py_INCREF(kws[2*i]);
PyTuple_SET_ITEM(kwnames, i, kws[2*i]);
- kwargs[i] = kws[2*i+1];
}
PyFrameConstructor constr = {
.fc_globals = globals,
More information about the Python-checkins
mailing list