[Python-checkins] bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules (GH-31358)

corona10 webhook-mailer at python.org
Wed Feb 16 04:57:53 EST 2022


https://github.com/python/cpython/commit/e59309b9d0969d5c8f493cb8df28afa6f38d6273
commit: e59309b9d0969d5c8f493cb8df28afa6f38d6273
branch: main
author: Dong-hee Na <donghee.na at python.org>
committer: corona10 <donghee.na92 at gmail.com>
date: 2022-02-16T18:57:28+09:00
summary:

bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules (GH-31358)

files:
M Modules/_dbmmodule.c
M Modules/_gdbmmodule.c

diff --git a/Modules/_dbmmodule.c b/Modules/_dbmmodule.c
index 65778fa77bfec..de8b2304ed8f1 100644
--- a/Modules/_dbmmodule.c
+++ b/Modules/_dbmmodule.c
@@ -3,7 +3,6 @@
 
 
 #define PY_SSIZE_T_CLEAN
-#define NEEDS_PY_IDENTIFIER
 #include "Python.h"
 
 #include <sys/types.h>
@@ -396,8 +395,7 @@ dbm__enter__(PyObject *self, PyObject *args)
 static PyObject *
 dbm__exit__(PyObject *self, PyObject *args)
 {
-    _Py_IDENTIFIER(close);
-    return _PyObject_CallMethodIdNoArgs(self, &PyId_close);
+    return _dbm_dbm_close_impl((dbmobject *)self);
 }
 
 static PyMethodDef dbm_methods[] = {
diff --git a/Modules/_gdbmmodule.c b/Modules/_gdbmmodule.c
index 2d690c0abfd08..e6440fa9cd364 100644
--- a/Modules/_gdbmmodule.c
+++ b/Modules/_gdbmmodule.c
@@ -4,7 +4,6 @@
 /* Doc strings: Mitch Chapman */
 
 #define PY_SSIZE_T_CLEAN
-#define NEEDS_PY_IDENTIFIER
 #include "Python.h"
 #include "gdbm.h"
 
@@ -545,8 +544,7 @@ gdbm__enter__(PyObject *self, PyObject *args)
 static PyObject *
 gdbm__exit__(PyObject *self, PyObject *args)
 {
-    _Py_IDENTIFIER(close);
-    return _PyObject_CallMethodIdNoArgs(self, &PyId_close);
+    return _gdbm_gdbm_close_impl((gdbmobject *)self);
 }
 
 static PyMethodDef gdbm_methods[] = {



More information about the Python-checkins mailing list