[Python-checkins] GH-100192: fix `asyncio` subprocess tests to pass env vars to subprocess (#100569)

kumaraditya303 webhook-mailer at python.org
Wed Dec 28 00:46:09 EST 2022


https://github.com/python/cpython/commit/6835184a44389747dd151023b31a20ff75d6a402
commit: 6835184a44389747dd151023b31a20ff75d6a402
branch: main
author: Kumar Aditya <59607654+kumaraditya303 at users.noreply.github.com>
committer: kumaraditya303 <59607654+kumaraditya303 at users.noreply.github.com>
date: 2022-12-28T11:16:04+05:30
summary:

GH-100192: fix `asyncio` subprocess tests to pass env vars to subprocess (#100569)

files:
M Lib/test/test_asyncio/test_subprocess.py

diff --git a/Lib/test/test_asyncio/test_subprocess.py b/Lib/test/test_asyncio/test_subprocess.py
index 1ae290a003f2..f1ad10a9903f 100644
--- a/Lib/test/test_asyncio/test_subprocess.py
+++ b/Lib/test/test_asyncio/test_subprocess.py
@@ -698,7 +698,8 @@ async def check_stdout_output(self, coro, output):
     def test_create_subprocess_env_shell(self) -> None:
         async def main() -> None:
             cmd = f'''{sys.executable} -c "import os, sys; sys.stdout.write(os.getenv('FOO'))"'''
-            env = {"FOO": 'bar'}
+            env = os.environ.copy()
+            env["FOO"] = "bar"
             proc = await asyncio.create_subprocess_shell(
                 cmd, env=env, stdout=subprocess.PIPE
             )
@@ -710,7 +711,8 @@ def test_create_subprocess_env_exec(self) -> None:
         async def main() -> None:
             cmd = [sys.executable, "-c",
                    "import os, sys; sys.stdout.write(os.getenv('FOO'))"]
-            env = {"FOO": 'baz'}
+            env = os.environ.copy()
+            env["FOO"] = "baz"
             proc = await asyncio.create_subprocess_exec(
                 *cmd, env=env, stdout=subprocess.PIPE
             )



More information about the Python-checkins mailing list