[Python-checkins] [3.11] gh-100474: Fix handling of dirs named index.html in http.server (GH-100505)

[merwok]

https://github.com/python/cpython/commit/714a93f6383042c1c12d9bdf2b5c2cdd7a72c20d
commit: 714a93f6383042c1c12d9bdf2b5c2cdd7a72c20d
branch: 3.11
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: merwok <merwok at netwok.org>
date: 2022-12-24T15:28:41-05:00
summary:

[3.11] gh-100474: Fix handling of dirs named index.html in http.server (GH-100505)

Co-authored-by: James Frost <git at frost.cx>

files:
A Misc/NEWS.d/next/Library/2022-12-23-21-02-43.gh-issue-100474.gppA4U.rst
M Lib/http/server.py
M Lib/test/test_httpservers.py

diff --git a/Lib/http/server.py b/Lib/http/server.py
index 058ee47ba10e..eef7cbb3ec75 100644
--- a/Lib/http/server.py
+++ b/Lib/http/server.py
@@ -708,7 +708,7 @@ def send_head(self):
                 return None
             for index in "index.html", "index.htm":
                 index = os.path.join(path, index)
-                if os.path.exists(index):
+                if os.path.isfile(index):
                     path = index
                     break
             else:
diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py
index ca078862cca6..cbcf94136ac4 100644
--- a/Lib/test/test_httpservers.py
+++ b/Lib/test/test_httpservers.py
@@ -489,6 +489,9 @@ def test_get(self):
         self.check_status_and_reason(response, HTTPStatus.NOT_FOUND)
         response = self.request('/' + 'ThisDoesNotExist' + '/')
         self.check_status_and_reason(response, HTTPStatus.NOT_FOUND)
+        os.makedirs(os.path.join(self.tempdir, 'spam', 'index.html'))
+        response = self.request(self.base_url + '/spam/')
+        self.check_status_and_reason(response, HTTPStatus.OK)
 
         data = b"Dummy index file\r\n"
         with open(os.path.join(self.tempdir_name, 'index.html'), 'wb') as f:
diff --git a/Misc/NEWS.d/next/Library/2022-12-23-21-02-43.gh-issue-100474.gppA4U.rst b/Misc/NEWS.d/next/Library/2022-12-23-21-02-43.gh-issue-100474.gppA4U.rst
new file mode 100644
index 000000000000..31abfb8b87fb
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-12-23-21-02-43.gh-issue-100474.gppA4U.rst
@@ -0,0 +1,2 @@
+:mod:`http.server` now checks that an index page is actually a regular file before trying
+to serve it.  This avoids issues with directories named ``index.html``.