[Python-checkins] gh-91954: Use shell=True in test_subprocess.test_encoding_warning (GH-92090)

sweeneyde webhook-mailer at python.org
Sat Apr 30 20:38:23 EDT 2022


https://github.com/python/cpython/commit/b9636180b32ea483f12564657ba1c3eb5b6d73d8
commit: b9636180b32ea483f12564657ba1c3eb5b6d73d8
branch: main
author: Dennis Sweeney <36520290+sweeneyde at users.noreply.github.com>
committer: sweeneyde <36520290+sweeneyde at users.noreply.github.com>
date: 2022-04-30T20:38:19-04:00
summary:

gh-91954: Use shell=True in test_subprocess.test_encoding_warning (GH-92090)

files:
M Lib/test/test_subprocess.py

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 5814a6d924e12..0764120952ebd 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -1736,16 +1736,15 @@ def test_run_with_shell_timeout_and_capture_output(self):
     def test_encoding_warning(self):
         code = textwrap.dedent("""\
             from subprocess import *
-            args = ["echo", "hello"]
-            run(args, text=True)
-            check_output(args, text=True)
+            run("echo hello", shell=True, text=True)
+            check_output("echo hello", shell=True, text=True)
             """)
         cp = subprocess.run([sys.executable, "-Xwarn_default_encoding", "-c", code],
                             capture_output=True)
         lines = cp.stderr.splitlines()
-        self.assertEqual(len(lines), 2)
-        self.assertTrue(lines[0].startswith(b"<string>:3: EncodingWarning: "))
-        self.assertTrue(lines[1].startswith(b"<string>:4: EncodingWarning: "))
+        self.assertEqual(len(lines), 2, lines)
+        self.assertTrue(lines[0].startswith(b"<string>:2: EncodingWarning: "))
+        self.assertTrue(lines[1].startswith(b"<string>:3: EncodingWarning: "))
 
 
 def _get_test_grp_name():



More information about the Python-checkins mailing list