[Python-checkins] gh-90699: Remove usage of _Py_IDENTIFIER from bisect module. (GH-91522)

corona10 webhook-mailer at python.org
Thu Apr 14 01:57:36 EDT 2022


https://github.com/python/cpython/commit/7b87e8af0cb8df0d76e8ab18a9b12affb4526103
commit: 7b87e8af0cb8df0d76e8ab18a9b12affb4526103
branch: main
author: Dong-hee Na <donghee.na at python.org>
committer: corona10 <donghee.na92 at gmail.com>
date: 2022-04-14T14:57:25+09:00
summary:

gh-90699: Remove usage of _Py_IDENTIFIER from bisect module. (GH-91522)

files:
M Modules/_bisectmodule.c

diff --git a/Modules/_bisectmodule.c b/Modules/_bisectmodule.c
index f884d94413c0d..c54dc4979d00b 100644
--- a/Modules/_bisectmodule.c
+++ b/Modules/_bisectmodule.c
@@ -4,7 +4,6 @@ Converted to C by Dmitry Vasiliev (dima at hlabs.spb.ru).
 */
 
 #define PY_SSIZE_T_CLEAN
-#define NEEDS_PY_IDENTIFIER
 #include "Python.h"
 
 /*[clinic input]
@@ -14,8 +13,6 @@ module _bisect
 
 #include "clinic/_bisectmodule.c.h"
 
-_Py_IDENTIFIER(insert);
-
 static inline Py_ssize_t
 internal_bisect_right(PyObject *list, PyObject *item, Py_ssize_t lo, Py_ssize_t hi,
                       PyObject* key)
@@ -132,7 +129,7 @@ _bisect_insort_right_impl(PyObject *module, PyObject *a, PyObject *x,
             return NULL;
     }
     else {
-        result = _PyObject_CallMethodId(a, &PyId_insert, "nO", index, x);
+        result = PyObject_CallMethod(a, "insert", "nO", index, x);
         if (result == NULL)
             return NULL;
         Py_DECREF(result);
@@ -258,7 +255,7 @@ _bisect_insort_left_impl(PyObject *module, PyObject *a, PyObject *x,
         if (PyList_Insert(a, index, x) < 0)
             return NULL;
     } else {
-        result = _PyObject_CallMethodId(a, &PyId_insert, "nO", index, x);
+        result = PyObject_CallMethod(a, "insert", "nO", index, x);
         if (result == NULL)
             return NULL;
         Py_DECREF(result);



More information about the Python-checkins mailing list