[Python-checkins] bpo-45574: fix warning about `print_escape` being unused (GH-29172) (#29176)
pablogsal
webhook-mailer at python.org
Sat Oct 23 09:35:57 EDT 2021
https://github.com/python/cpython/commit/cadf06eab75c887dfc753ca80ef35cd2a7871135
commit: cadf06eab75c887dfc753ca80ef35cd2a7871135
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: pablogsal <Pablogsal at gmail.com>
date: 2021-10-23T14:35:48+01:00
summary:
bpo-45574: fix warning about `print_escape` being unused (GH-29172) (#29176)
It used to be like this:
<img width="1232" alt="Снимок экрана 2021-10-22 в 23 07 40" src="https://user-images.githubusercontent.com/4660275/138516608-fef6ec01-a96a-40f4-81ef-52265b0f536b.png">
Quick `grep` tells that it is just used in one place under `Py_DEBUG`: https://github.com/python/cpython/blame/f6e8b80d20159596cf641305bad3a833bedd2f4f/Parser/tokenizer.cGH-L1047-L1051
<img width="752" alt="Снимок экрана 2021-10-22 в 23 08 09" src="https://user-images.githubusercontent.com/4660275/138516684-ea503136-1e92-48a5-95bb-419e190d5866.png">
I am not sure, but it also looks like a private thing, it should not affect other users.
Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 4bc5473a42c5eae0928430930b897209492e849d)
Co-authored-by: Nikita Sobolev <mail at sobolevn.me>
Co-authored-by: Nikita Sobolev <mail at sobolevn.me>
files:
A Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst
M Parser/tokenizer.c
diff --git a/Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst b/Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst
new file mode 100644
index 0000000000000..b404d24473960
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst
@@ -0,0 +1 @@
+Fix warning about ``print_escape`` being unused.
diff --git a/Parser/tokenizer.c b/Parser/tokenizer.c
index 53c10282ce86a..cd348487e0fd5 100644
--- a/Parser/tokenizer.c
+++ b/Parser/tokenizer.c
@@ -994,6 +994,7 @@ tok_underflow_file(struct tok_state *tok) {
return tok->done == E_OK;
}
+#if defined(Py_DEBUG)
static void
print_escape(FILE *f, const char *s, Py_ssize_t size)
{
@@ -1020,6 +1021,7 @@ print_escape(FILE *f, const char *s, Py_ssize_t size)
}
putc('"', f);
}
+#endif
/* Get next char, updating state; error code goes into tok->done */
More information about the Python-checkins
mailing list