[Python-checkins] bpo-42064: Remove stale extern declarations in `sqlite3` headers (GH-26840)
corona10
webhook-mailer at python.org
Wed Jun 23 08:07:01 EDT 2021
https://github.com/python/cpython/commit/019ad62afd20e80c74f879aa716e339b992a0bb9
commit: 019ad62afd20e80c74f879aa716e339b992a0bb9
branch: main
author: Erlend Egeberg Aasland <erlend.aasland at innova.no>
committer: corona10 <donghee.na92 at gmail.com>
date: 2021-06-23T21:06:53+09:00
summary:
bpo-42064: Remove stale extern declarations in `sqlite3` headers (GH-26840)
files:
M Modules/_sqlite/connection.h
M Modules/_sqlite/cursor.h
M Modules/_sqlite/prepare_protocol.h
M Modules/_sqlite/row.h
M Modules/_sqlite/statement.h
M Tools/c-analyzer/cpython/ignored.tsv
diff --git a/Modules/_sqlite/connection.h b/Modules/_sqlite/connection.h
index 88c58b385ba844..5e7e7e5abe0668 100644
--- a/Modules/_sqlite/connection.h
+++ b/Modules/_sqlite/connection.h
@@ -98,8 +98,6 @@ typedef struct
PyObject* NotSupportedError;
} pysqlite_Connection;
-extern PyTypeObject *pysqlite_ConnectionType;
-
int pysqlite_connection_register_cursor(pysqlite_Connection* connection, PyObject* cursor);
int pysqlite_check_thread(pysqlite_Connection* self);
int pysqlite_check_connection(pysqlite_Connection* con);
diff --git a/Modules/_sqlite/cursor.h b/Modules/_sqlite/cursor.h
index b26b2886746c29..9a5e9eede23025 100644
--- a/Modules/_sqlite/cursor.h
+++ b/Modules/_sqlite/cursor.h
@@ -52,8 +52,6 @@ typedef struct
PyObject* in_weakreflist; /* List of weak references */
} pysqlite_Cursor;
-extern PyTypeObject *pysqlite_CursorType;
-
int pysqlite_cursor_setup_types(PyObject *module);
#define UNKNOWN (-1)
diff --git a/Modules/_sqlite/prepare_protocol.h b/Modules/_sqlite/prepare_protocol.h
index 593961331c90da..f24cef5497139f 100644
--- a/Modules/_sqlite/prepare_protocol.h
+++ b/Modules/_sqlite/prepare_protocol.h
@@ -30,8 +30,6 @@ typedef struct
PyObject_HEAD
} pysqlite_PrepareProtocol;
-extern PyTypeObject *pysqlite_PrepareProtocolType;
-
int pysqlite_prepare_protocol_setup_types(PyObject *module);
#define UNKNOWN (-1)
diff --git a/Modules/_sqlite/row.h b/Modules/_sqlite/row.h
index 2dac41e89e12d8..b51909817584ba 100644
--- a/Modules/_sqlite/row.h
+++ b/Modules/_sqlite/row.h
@@ -33,8 +33,6 @@ typedef struct _Row
PyObject* description;
} pysqlite_Row;
-extern PyTypeObject *pysqlite_RowType;
-
int pysqlite_row_setup_types(PyObject *module);
#endif
diff --git a/Modules/_sqlite/statement.h b/Modules/_sqlite/statement.h
index b06f6155e15c2f..70801cc5ce9fdb 100644
--- a/Modules/_sqlite/statement.h
+++ b/Modules/_sqlite/statement.h
@@ -38,8 +38,6 @@ typedef struct
PyObject* in_weakreflist; /* List of weak references */
} pysqlite_Statement;
-extern PyTypeObject *pysqlite_StatementType;
-
pysqlite_Statement *pysqlite_statement_create(pysqlite_Connection *connection, PyObject *sql);
int pysqlite_statement_bind_parameter(pysqlite_Statement* self, int pos, PyObject* parameter);
diff --git a/Tools/c-analyzer/cpython/ignored.tsv b/Tools/c-analyzer/cpython/ignored.tsv
index e5d93782076c3d..d8407ed3745faf 100644
--- a/Tools/c-analyzer/cpython/ignored.tsv
+++ b/Tools/c-analyzer/cpython/ignored.tsv
@@ -49,13 +49,6 @@ Modules/_io/_iomodule.h - _PyIO_str_write -
Modules/_io/_iomodule.h - _PyIO_empty_str -
Modules/_io/_iomodule.h - _PyIO_empty_bytes -
Modules/_multiprocessing/multiprocessing.h - _PyMp_SemLockType -
-Modules/_sqlite/cache.h - pysqlite_NodeType -
-Modules/_sqlite/cache.h - pysqlite_CacheType -
-Modules/_sqlite/cursor.h - pysqlite_CursorType -
-Modules/_sqlite/row.h - pysqlite_RowType -
-Modules/_sqlite/prepare_protocol.h - pysqlite_PrepareProtocolType -
-Modules/_sqlite/statement.h - pysqlite_StatementType -
-Modules/_sqlite/connection.h - pysqlite_ConnectionType -
Modules/_sqlite/module.c - pysqlite_Error -
Modules/_sqlite/module.c - pysqlite_Warning -
Modules/_sqlite/module.c - pysqlite_InterfaceError -
@@ -2372,13 +2365,6 @@ Modules/_tkinter.c - Tktt_Type -
Modules/xxlimited.c - Xxo_Type -
Modules/_decimal/_decimal.c - DecimalTuple -
Modules/_decimal/_decimal.c - PyDecSignalDict_Type -
-Modules/_sqlite/connection.c - pysqlite_ConnectionType -
-Modules/_sqlite/statement.c - pysqlite_StatementType -
-Modules/_sqlite/cache.c - pysqlite_NodeType -
-Modules/_sqlite/cache.c - pysqlite_CacheType -
-Modules/_sqlite/row.c - pysqlite_RowType -
-Modules/_sqlite/prepare_protocol.c - pysqlite_PrepareProtocolType -
-Modules/_sqlite/cursor.c - pysqlite_CursorType -
# exception types []
Modules/_ctypes/_ctypes.c - PyExc_ArgError -
More information about the Python-checkins
mailing list