[Python-checkins] bpo-44409: Fix error location in tokenizer errors that happen during initialization (GH-26712)
pablogsal
webhook-mailer at python.org
Mon Jun 14 12:46:33 EDT 2021
https://github.com/python/cpython/commit/507ed6fa1d6661e0f8e6d3282764aa9625a99594
commit: 507ed6fa1d6661e0f8e6d3282764aa9625a99594
branch: main
author: Pablo Galindo <Pablogsal at gmail.com>
committer: pablogsal <Pablogsal at gmail.com>
date: 2021-06-14T17:46:11+01:00
summary:
bpo-44409: Fix error location in tokenizer errors that happen during initialization (GH-26712)
files:
A Misc/NEWS.d/next/Core and Builtins/2021-06-13-23-12-18.bpo-44409.eW4LS-.rst
M Lib/test/test_exceptions.py
M Parser/pegen.c
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index 9cb5466a674d1..d444a122af9be 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -246,6 +246,7 @@ def baz():
check("pass\npass\npass\n(1+)\npass\npass\npass", 4, 4)
check("(1+)", 1, 4)
check("[interesting\nfoo()\n", 1, 1)
+ check(b"\xef\xbb\xbf#coding: utf8\nprint('\xe6\x88\x91')\n", 0, -1)
# Errors thrown by symtable.c
check('x = [(yield i) for i in range(3)]', 1, 5)
diff --git a/Misc/NEWS.d/next/Core and Builtins/2021-06-13-23-12-18.bpo-44409.eW4LS-.rst b/Misc/NEWS.d/next/Core and Builtins/2021-06-13-23-12-18.bpo-44409.eW4LS-.rst
new file mode 100644
index 0000000000000..0f204ed812b27
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2021-06-13-23-12-18.bpo-44409.eW4LS-.rst
@@ -0,0 +1,2 @@
+Fix error location information for tokenizer errors raised on initialization
+of the tokenizer. Patch by Pablo Galindo.
diff --git a/Parser/pegen.c b/Parser/pegen.c
index 19412446b118a..615047c1b6a00 100644
--- a/Parser/pegen.c
+++ b/Parser/pegen.c
@@ -283,6 +283,7 @@ static void
raise_tokenizer_init_error(PyObject *filename)
{
if (!(PyErr_ExceptionMatches(PyExc_LookupError)
+ || PyErr_ExceptionMatches(PyExc_SyntaxError)
|| PyErr_ExceptionMatches(PyExc_ValueError)
|| PyErr_ExceptionMatches(PyExc_UnicodeDecodeError))) {
return;
More information about the Python-checkins
mailing list