[Python-checkins] bpo-44479: Do not regenerate files during a PGO build as it will invalidate the profile. (GH-27462)

zooba webhook-mailer at python.org
Thu Jul 29 18:18:37 EDT 2021


https://github.com/python/cpython/commit/0b984d1cccc9547c2c16203e9ab2b2959fbabcde
commit: 0b984d1cccc9547c2c16203e9ab2b2959fbabcde
branch: 3.10
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2021-07-29T23:18:17+01:00
summary:

bpo-44479: Do not regenerate files during a PGO build as it will invalidate the profile. (GH-27462)

Also remove some unused code that should not have been backported.

files:
M PCbuild/regen.targets

diff --git a/PCbuild/regen.targets b/PCbuild/regen.targets
index a1de340ab544c..ff56d1148e845 100644
--- a/PCbuild/regen.targets
+++ b/PCbuild/regen.targets
@@ -78,16 +78,14 @@
           WorkingDirectory="$(PySourcePath)" />
   </Target>
 
-  <Target Name="Regen" DependsOnTargets="_TouchRegenSources;_RegenPegen;_RegenAST_H;_RegenOpcodes;_RegenTokens;_RegenKeywords">
+  <Target Name="Regen"
+          Condition="$(Configuration) != 'PGUpdate'"
+          DependsOnTargets="_TouchRegenSources;_RegenPegen;_RegenAST_H;_RegenOpcodes;_RegenTokens;_RegenKeywords">
     <Message Text="Generated sources are up to date" Importance="high" />
   </Target>
 
 
   <ItemGroup>
-    <_TestFrozenSources Include="$(PySourcePath)Programs\freeze_test_frozenmain.py;
-                                 $(PySourcePath)Programs\test_frozenmain.py;
-                                 @(_OpcodeOutputs)" />
-    <_TestFrozenOutputs Include="$(PySourcePath)Programs\test_frozenmain.h" />
     <_LicenseSources Include="$(PySourcePath)LICENSE;
                               $(PySourcePath)PC\crtlicense.txt;
                               $(bz2Dir)LICENSE;
@@ -112,5 +110,7 @@
     <Message Text="Wrote $(OutDir)LICENSE.txt" Importance="high" />
   </Target>
 
-  <Target Name="PostBuildRegen" DependsOnTargets="_RegenLicense" />
+  <Target Name="PostBuildRegen"
+          Condition="$(Configuration) != 'PGInstrument' and $(Configuration) != 'PGUpdate'"
+          DependsOnTargets="_RegenLicense" />
 </Project>



More information about the Python-checkins mailing list