[Python-checkins] bpo-44479: Do not regenerate files during a PGO build as it will invalidate the profile. (GH-27460)

zooba webhook-mailer at python.org
Thu Jul 29 15:53:33 EDT 2021


https://github.com/python/cpython/commit/3edec5d142365f2340865b4f12652e6aa627818a
commit: 3edec5d142365f2340865b4f12652e6aa627818a
branch: main
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2021-07-29T20:53:29+01:00
summary:

bpo-44479: Do not regenerate files during a PGO build as it will invalidate the profile. (GH-27460)

files:
M PCbuild/regen.targets

diff --git a/PCbuild/regen.targets b/PCbuild/regen.targets
index 38f82d1b31a7f..27fdd6e29b8bc 100644
--- a/PCbuild/regen.targets
+++ b/PCbuild/regen.targets
@@ -78,7 +78,9 @@
           WorkingDirectory="$(PySourcePath)" />
   </Target>
 
-  <Target Name="Regen" DependsOnTargets="_TouchRegenSources;_RegenPegen;_RegenAST_H;_RegenOpcodes;_RegenTokens;_RegenKeywords">
+  <Target Name="Regen"
+          Condition="$(Configuration) != 'PGUpdate'"
+          DependsOnTargets="_TouchRegenSources;_RegenPegen;_RegenAST_H;_RegenOpcodes;_RegenTokens;_RegenKeywords">
     <Message Text="Generated sources are up to date" Importance="high" />
   </Target>
 
@@ -119,5 +121,7 @@
     <Message Text="Wrote $(OutDir)LICENSE.txt" Importance="high" />
   </Target>
 
-  <Target Name="PostBuildRegen" DependsOnTargets="_RegenTestFrozenmain;_RegenLicense" />
+  <Target Name="PostBuildRegen"
+          Condition="$(Configuration) != 'PGInstrument' and $(Configuration) != 'PGUpdate'"
+          DependsOnTargets="_RegenTestFrozenmain;_RegenLicense" />
 </Project>



More information about the Python-checkins mailing list