[Python-checkins] bpo-44353: Improve tests covering typing.NewType pickling (GH-27302)

ambv webhook-mailer at python.org
Sat Jul 24 05:53:45 EDT 2021


https://github.com/python/cpython/commit/a22b05da87bdfb081d6aaecfce136ae8dbb8680c
commit: a22b05da87bdfb081d6aaecfce136ae8dbb8680c
branch: main
author: Yurii Karabas <1998uriyyo at gmail.com>
committer: ambv <lukasz at langa.pl>
date: 2021-07-24T11:53:40+02:00
summary:

bpo-44353: Improve tests covering typing.NewType pickling (GH-27302)

files:
M Lib/test/test_typing.py

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 13ac395f769c6..85cb527a24db2 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -3755,16 +3755,17 @@ def test_repr(self):
     def test_pickle(self):
         UserAge = self.module.NewType('UserAge', float)
         for proto in range(pickle.HIGHEST_PROTOCOL + 1):
-            pickled = pickle.dumps(UserId, proto)
-            loaded = pickle.loads(pickled)
-            self.assertIs(loaded, UserId)
+            with self.subTest(proto=proto):
+                pickled = pickle.dumps(UserId, proto)
+                loaded = pickle.loads(pickled)
+                self.assertIs(loaded, UserId)
 
-            pickled = pickle.dumps(self.UserName, proto)
-            loaded = pickle.loads(pickled)
-            self.assertIs(loaded, self.UserName)
+                pickled = pickle.dumps(self.UserName, proto)
+                loaded = pickle.loads(pickled)
+                self.assertIs(loaded, self.UserName)
 
-            with self.assertRaises(pickle.PicklingError):
-                pickle.dumps(UserAge, proto)
+                with self.assertRaises(pickle.PicklingError):
+                    pickle.dumps(UserAge, proto)
 
 
 class NewTypePythonTests(NewTypeTests, BaseTestCase):



More information about the Python-checkins mailing list