[Python-checkins] Correct the order of check-abidump (GH-27230)

pablogsal webhook-mailer at python.org
Sun Jul 18 11:53:25 EDT 2021


https://github.com/python/cpython/commit/e05afef3c6182f4b81f0eabc06b361487fbd58cb
commit: e05afef3c6182f4b81f0eabc06b361487fbd58cb
branch: 3.9
author: Pablo Galindo Salgado <Pablogsal at gmail.com>
committer: pablogsal <Pablogsal at gmail.com>
date: 2021-07-18T16:53:14+01:00
summary:

Correct the order of check-abidump (GH-27230)

The check was backwards so we were not correctly detecting removals.

files:
M Makefile.pre.in

diff --git a/Makefile.pre.in b/Makefile.pre.in
index 2b68571031883..6ce7a614dce23 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -762,7 +762,7 @@ regen-abidump: all
 	@$(UPDATE_FILE) $(srcdir)/Doc/data/python$(LDVERSION).abi $(srcdir)/Doc/data/python$(LDVERSION).abi.new
 
 check-abidump: all
-		abidiff "libpython$(LDVERSION).so" $(srcdir)/Doc/data/python$(LDVERSION).abi --drop-private-types --no-architecture --no-added-syms
+		abidiff $(srcdir)/Doc/data/python$(LDVERSION).abi "libpython$(LDVERSION).so" --drop-private-types --no-architecture --no-added-syms
 
 ############################################################################
 # Regenerate all generated files



More information about the Python-checkins mailing list