[Python-checkins] bpo-43316: gzip: Fix sys.exit() usage. (GH-24652)

methane webhook-mailer at python.org
Thu Feb 25 21:09:24 EST 2021


https://github.com/python/cpython/commit/9525a18b5bb317d9fb206c992ab62aa41559b0c8
commit: 9525a18b5bb317d9fb206c992ab62aa41559b0c8
branch: master
author: Inada Naoki <songofacandy at gmail.com>
committer: methane <songofacandy at gmail.com>
date: 2021-02-26T11:09:06+09:00
summary:

bpo-43316: gzip: Fix sys.exit() usage. (GH-24652)

files:
M Lib/gzip.py
M Lib/test/test_gzip.py

diff --git a/Lib/gzip.py b/Lib/gzip.py
index 8002b43bde97c..ee0cbed8f50d6 100644
--- a/Lib/gzip.py
+++ b/Lib/gzip.py
@@ -583,7 +583,7 @@ def main():
                 g = sys.stdout.buffer
             else:
                 if arg[-3:] != ".gz":
-                    sys.exit("filename doesn't end in .gz:", repr(arg))
+                    sys.exit(f"filename doesn't end in .gz: {arg!r}")
                 f = open(arg, "rb")
                 g = builtins.open(arg[:-3], "wb")
         else:
diff --git a/Lib/test/test_gzip.py b/Lib/test/test_gzip.py
index 1bb8f7a2d351c..1dcfa2b628a1c 100644
--- a/Lib/test/test_gzip.py
+++ b/Lib/test/test_gzip.py
@@ -775,7 +775,7 @@ def test_decompress_infile_outfile(self):
 
     def test_decompress_infile_outfile_error(self):
         rc, out, err = assert_python_failure('-m', 'gzip', '-d', 'thisisatest.out')
-        self.assertIn(b"filename doesn't end in .gz:", err)
+        self.assertEqual(b"filename doesn't end in .gz: 'thisisatest.out'", err.strip())
         self.assertEqual(rc, 1)
         self.assertEqual(out, b'')
 



More information about the Python-checkins mailing list