[Python-checkins] bpo-45919: Remove out of date comment (GH-30090)
corona10
webhook-mailer at python.org
Mon Dec 13 20:31:46 EST 2021
https://github.com/python/cpython/commit/9130a4d62032468e0d4949aaa49c29afb0d854ca
commit: 9130a4d62032468e0d4949aaa49c29afb0d854ca
branch: main
author: Dong-hee Na <donghee.na at python.org>
committer: corona10 <donghee.na92 at gmail.com>
date: 2021-12-14T10:31:41+09:00
summary:
bpo-45919: Remove out of date comment (GH-30090)
files:
M Python/pylifecycle.c
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index 22281a311918e..b2f58f4e3e8a3 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -2166,13 +2166,15 @@ is_valid_fd(int fd)
some platforms.
fcntl(fd, F_GETFD) is even faster, because it only checks the process table.
+ It is preferred over dup() when available, since it cannot fail with the
+ "too many open files" error (EMFILE).
bpo-30225: On macOS Tiger, when stdout is redirected to a pipe and the other
side of the pipe is closed, dup(1) succeed, whereas fstat(1, &st) fails with
EBADF. FreeBSD has similar issue (bpo-32849).
- Only use dup() on platforms where dup() is enough to detect invalid FD in
- corner cases: on Linux and Windows (bpo-32849).
+ Only use dup() on Linux where dup() is enough to detect invalid FD
+ (bpo-32849).
*/
if (fd < 0) {
return 0;
More information about the Python-checkins
mailing list