[Python-checkins] bpo-43888: Remove coverage builds from CI (GH-25679)
brettcannon
webhook-mailer at python.org
Fri Apr 30 17:04:48 EDT 2021
https://github.com/python/cpython/commit/726c931b3896dc73fd156e2340b5ef0b8f55cfb7
commit: 726c931b3896dc73fd156e2340b5ef0b8f55cfb7
branch: master
author: Ammar Askar <ammar at ammaraskar.com>
committer: brettcannon <brett at python.org>
date: 2021-04-30T14:04:40-07:00
summary:
bpo-43888: Remove coverage builds from CI (GH-25679)
The coverage builds were consistently timing out in CI, suggesting that people were not reviewing the uploaded reports.
files:
D .github/codecov.yml
D .github/workflows/coverage.yml
M .travis.yml
M README.rst
diff --git a/.github/codecov.yml b/.github/codecov.yml
deleted file mode 100644
index ea504f48672eac..00000000000000
--- a/.github/codecov.yml
+++ /dev/null
@@ -1,30 +0,0 @@
-codecov:
- strict_yaml_branch: master
- notify:
- require_ci_to_pass: true
-comment: off
-ignore:
- - "Doc/**/*"
- - "Misc/**/*"
- - "Mac/**/*"
- - "PC/**/*"
- - "PCbuild/**/*"
- - "Tools/**/*"
- - "Grammar/*"
-coverage:
- precision: 2
- range: 70...90
- round: down
- status:
- changes: off
- project: off
- patch: off
-parsers:
- gcov:
- branch_detection:
- conditional: true
- loop: true
- macro: false
- method: false
- javascript:
- enable_partials: false
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
deleted file mode 100644
index 1480a92b5c4400..00000000000000
--- a/.github/workflows/coverage.yml
+++ /dev/null
@@ -1,95 +0,0 @@
-name: Coverage
-
-on:
- push:
- branches:
- - master
- - 3.9
- - 3.8
- - 3.7
- paths-ignore:
- - 'Doc/**'
- - 'Misc/**'
- #pull_request:
- # branches:
- # - master
- # - 3.9
- # - 3.8
- # - 3.7
- # paths-ignore:
- # - 'Doc/**'
- # - 'Misc/**'
-
-jobs:
- coverage_ubuntu:
- name: 'Ubuntu (Coverage)'
- runs-on: ubuntu-latest
- env:
- OPENSSL_VER: 1.1.1k
- steps:
- - uses: actions/checkout at v2
- - name: Install Dependencies
- run: sudo ./.github/workflows/posix-deps-apt.sh
- - name: 'Restore OpenSSL build'
- id: cache-openssl
- uses: actions/cache at v2.1.4
- with:
- path: ./multissl/openssl/${{ env.OPENSSL_VER }}
- key: ${{ runner.os }}-multissl-openssl-${{ env.OPENSSL_VER }}
- - name: Install OpenSSL
- if: steps.cache-openssl.outputs.cache-hit != 'true'
- run: python3 Tools/ssl/multissltests.py --steps=library --base-directory $PWD/multissl --openssl $OPENSSL_VER --system Linux
- - name: Configure CPython
- run: ./configure --with-openssl=$PWD/multissl/openssl/$OPENSSL_VER
- - name: Build CPython
- run: make -j4
- - name: Display build info
- run: make pythoninfo
- - name: 'Coverage Preparation'
- run: |
- ./python -m venv .venv
- source ./.venv/bin/activate
- python -m pip install -U coverage
- python -m pip install -r Misc/requirements-test.txt
- python -m test.pythoninfo
- export PYTHONPATH=`find .venv -name fullcoverage`
- - name: 'Tests with coverage'
- timeout-minutes: 100 # 1h40m, ref https://bugs.python.org/issue43888
- run: >
- source ./.venv/bin/activate &&
- xvfb-run python -m coverage
- run --branch --pylib
- -m test
- --fail-env-changed
- -uall,-cpu
- -x test_multiprocessing_fork
- -x test_multiprocessing_forkserver
- -x test_multiprocessing_spawn
- -x test_concurrent_futures
- || true
- - name: 'Publish code coverage results'
- run: |
- export PYTHONPATH=
- source ./.venv/bin/activate
- bash <(curl -s https://codecov.io/bash) -y .github/codecov.yml
- env:
- CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-
- c_coverage_ubuntu:
- name: 'Ubuntu (C Coverage)'
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout at v2
- - name: Install Dependencies
- run: sudo ./.github/workflows/posix-deps-apt.sh
- - name: Configure CPython
- run: ./configure
- - name: 'Build CPython and measure coverage'
- run: xvfb-run make -j4 coverage-report
- - name: 'Publish code coverage results'
- if: always()
- run: |
- make pythoninfo
- bash <(curl -s https://codecov.io/bash) -y .github/codecov.yml
- env:
- CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.travis.yml b/.travis.yml
index fc063216914446..1112a0b266227b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -69,61 +69,6 @@ matrix:
- make -C Doc/ PYTHON=../python venv
script:
xvfb-run make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W -j4" doctest
- - name: "Test code coverage (Python)"
- os: linux
- language: c
- compiler: gcc
- env: OPTIONAL=true
- addons:
- apt:
- packages:
- - xvfb
- before_script:
- - |
- if [[ "$TRAVIS_PULL_REQUEST" != "false" ]]
- then
- echo "Don't run Python coverage on pull requests."
- exit
- fi
- - ./configure
- - make -j4
- # Need a venv that can parse covered code.
- - ./python -m venv venv
- - ./venv/bin/python -m pip install -U coverage
- - ./venv/bin/python -m pip install -r Misc/requirements-test.txt
- - ./venv/bin/python -m test.pythoninfo
- - export PYTHONPATH=`find venv -name fullcoverage`
- script:
- # Skip tests that re-run the entire test suite.
- - xvfb-run ./venv/bin/python -m coverage run --branch --pylib -m test --fail-env-changed -uall,-cpu -x test_multiprocessing_fork -x test_multiprocessing_forkserver -x test_multiprocessing_spawn -x test_concurrent_futures || true
- after_script: # Probably should be after_success once test suite updated to run under coverage.py.
- # Make the `coverage` command available to Codecov w/ a version of Python that can parse all source files.
- - export PYTHONPATH=
- - source ./venv/bin/activate
- - bash <(curl -s https://codecov.io/bash) -y .github/codecov.yml
- - name: "Test code coverage (C)"
- os: linux
- language: c
- compiler: gcc
- env: OPTIONAL=true
- addons:
- apt:
- packages:
- - lcov
- - xvfb
- before_script:
- - |
- if [[ "$TRAVIS_PULL_REQUEST" != "false" ]]
- then
- echo "Don't run C coverage on pull requests."
- exit
- fi
- - ./configure
- script:
- - xvfb-run make -j4 coverage-report
- after_script: # Probably should be after_success once test suite updated to run under coverage.py.
- - make pythoninfo
- - bash <(curl -s https://codecov.io/bash) -y .github/codecov.yml
before_install:
diff --git a/README.rst b/README.rst
index 02a34d28aa489a..18d6e6a96f937e 100644
--- a/README.rst
+++ b/README.rst
@@ -13,10 +13,6 @@ This is Python version 3.10.0 alpha 7
:alt: CPython build status on Azure DevOps
:target: https://dev.azure.com/python/cpython/_build/latest?definitionId=4&branchName=master
-.. image:: https://codecov.io/gh/python/cpython/branch/master/graph/badge.svg
- :alt: CPython code coverage on Codecov
- :target: https://codecov.io/gh/python/cpython
-
.. image:: https://img.shields.io/badge/discourse-join_chat-brightgreen.svg
:alt: Python Discourse chat
:target: https://discuss.python.org/
More information about the Python-checkins
mailing list