[Python-checkins] bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684)

[vstinner]

https://github.com/python/cpython/commit/fe52eb62191e640e720d184a9a1a04e965b8a062
commit: fe52eb62191e640e720d184a9a1a04e965b8a062
branch: master
author: Victor Stinner <vstinner at python.org>
committer: vstinner <vstinner at python.org>
date: 2021-04-28T15:47:10+02:00
summary:

bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684)

Fix test_logging.test_namer_rotator_inheritance() on Windows: use
os.replace() rather than os.rename().

files:
A Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst
M Lib/test/test_logging.py

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index bb31e29ca76911..1d061e4993ce0e 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -5219,7 +5219,7 @@ def namer(self, name):
 
             def rotator(self, source, dest):
                 if os.path.exists(source):
-                    os.rename(source, dest + ".rotated")
+                    os.replace(source, dest + ".rotated")
 
         rh = HandlerWithNamerAndRotator(
             self.fn, encoding="utf-8", backupCount=2, maxBytes=1)
diff --git a/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst
new file mode 100644
index 00000000000000..e56572f5170998
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst
@@ -0,0 +1,2 @@
+Fix test_logging.test_namer_rotator_inheritance() on Windows: use
+:func:`os.replace` rather than :func:`os.rename`. Patch by Victor Stinner.