[Python-checkins] bpo-1635741: Fix NULL ptr deref in multiprocessing (GH-22880)

[miss-islington]

https://github.com/python/cpython/commit/dde91b1953c0f0d51c4dde056727ff84b7655190
commit: dde91b1953c0f0d51c4dde056727ff84b7655190
branch: master
author: Christian Heimes <christian at python.org>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2020-10-22T03:20:36-07:00
summary:

bpo-1635741: Fix NULL ptr deref in multiprocessing (GH-22880)



Commit 1d541c25c8019f7a0b80b3e1b437abe171e40b65 introduced a NULL
pointer dereference in error path.

Signed-off-by: Christian Heimes <christian at python.org>

files:
M Modules/_multiprocessing/multiprocessing.c

diff --git a/Modules/_multiprocessing/multiprocessing.c b/Modules/_multiprocessing/multiprocessing.c
index 25b8dc3967a4f..bec23517fca51 100644
--- a/Modules/_multiprocessing/multiprocessing.c
+++ b/Modules/_multiprocessing/multiprocessing.c
@@ -207,7 +207,6 @@ multiprocessing_exec(PyObject *module)
             py_sem_value_max = PyLong_FromLong(SEM_VALUE_MAX);
 
         if (py_sem_value_max == NULL) {
-            Py_DECREF(py_sem_value_max);
             return -1;
         }
         if (PyDict_SetItemString(_PyMp_SemLockType.tp_dict, "SEM_VALUE_MAX",