[Python-checkins] bpo-41818: test_openpty succeed on Gentoo, don't expect to fail on this platform (GH-23514)

asvetlov webhook-mailer at python.org
Wed Nov 25 12:06:21 EST 2020


https://github.com/python/cpython/commit/87f7ab5359bc12eeb858272b7bd58e132cb9c176
commit: 87f7ab5359bc12eeb858272b7bd58e132cb9c176
branch: master
author: Andrew Svetlov <andrew.svetlov at gmail.com>
committer: asvetlov <andrew.svetlov at gmail.com>
date: 2020-11-25T19:06:12+02:00
summary:

bpo-41818: test_openpty succeed on Gentoo, don't expect to fail on this platform (GH-23514)

files:
M Lib/test/test_pty.py

diff --git a/Lib/test/test_pty.py b/Lib/test/test_pty.py
index 7de568806ed7d..138560e0309ab 100644
--- a/Lib/test/test_pty.py
+++ b/Lib/test/test_pty.py
@@ -5,6 +5,7 @@
 import_module('termios')
 
 import errno
+import pathlib
 import pty
 import os
 import sys
@@ -75,6 +76,19 @@ def _readline(fd):
 
 def expectedFailureIfStdinIsTTY(fun):
     # avoid isatty() for now
+    PLATFORM = platform.system()
+    if PLATFORM == "Linux":
+        os_release = pathlib.Path("/etc/os-release")
+        if os_release.exists():
+            # Actually the file has complex multi-line structure,
+            # these is no need to parse it for Gentoo check
+            if 'gentoo' in os_release.read_text().lower():
+                # bpo-41818:
+                # Gentoo passes the test,
+                # all other tested Linux distributions fail.
+                # Should not apply @unittest.expectedFailure() on Gentoo
+                # to keep the buildbot fleet happy.
+                return fun
     try:
         tty.tcgetattr(pty.STDIN_FILENO)
         return unittest.expectedFailure(fun)



More information about the Python-checkins mailing list