[Python-checkins] bpo-30064: Fix unstable asyncio "racing" socket tests (GH-20485)

Victor Stinner webhook-mailer at python.org
Thu May 28 10:08:58 EDT 2020


https://github.com/python/cpython/commit/84ee7e1573d166fe7a9be676813e12523b62ab24
commit: 84ee7e1573d166fe7a9be676813e12523b62ab24
branch: master
author: Victor Stinner <vstinner at python.org>
committer: GitHub <noreply at github.com>
date: 2020-05-28T16:08:50+02:00
summary:

bpo-30064: Fix unstable asyncio "racing" socket tests (GH-20485)

Skip new "racing" socket tests which fail randomly until someone fix
them, to ease analysis of buildbot failures (skip tests which are
known to be broken/unstable).

files:
M Lib/test/test_asyncio/test_sock_lowlevel.py

diff --git a/Lib/test/test_asyncio/test_sock_lowlevel.py b/Lib/test/test_asyncio/test_sock_lowlevel.py
index 5e6a90abb46cf..e0583c0419564 100644
--- a/Lib/test/test_asyncio/test_sock_lowlevel.py
+++ b/Lib/test/test_asyncio/test_sock_lowlevel.py
@@ -2,6 +2,8 @@
 import time
 import asyncio
 import sys
+import unittest
+
 from asyncio import proactor_events
 from itertools import cycle, islice
 from test.test_asyncio import utils as test_utils
@@ -232,6 +234,8 @@ async def _basetest_sock_connect_racing(self, listener, sock):
                 # avoid touching event loop to maintain race condition
                 time.sleep(0.01)
 
+    # FIXME: https://bugs.python.org/issue30064#msg370143
+    @unittest.skipIf(True, "unstable test")
     def test_sock_client_racing(self):
         with test_utils.run_test_server() as httpd:
             sock = socket.socket()



More information about the Python-checkins mailing list