[Python-checkins] bpo-36543: Remove the xml.etree.cElementTree module. (GH-19108)
Serhiy Storchaka
webhook-mailer at python.org
Sun Mar 22 08:31:50 EDT 2020
https://github.com/python/cpython/commit/b33e52511a59c6da7132c226b7f7489b092a33eb
commit: b33e52511a59c6da7132c226b7f7489b092a33eb
branch: master
author: Serhiy Storchaka <storchaka at gmail.com>
committer: GitHub <noreply at github.com>
date: 2020-03-22T14:31:38+02:00
summary:
bpo-36543: Remove the xml.etree.cElementTree module. (GH-19108)
files:
D Lib/xml/etree/cElementTree.py
M Lib/test/test_xml_etree_c.py
diff --git a/Lib/test/test_xml_etree_c.py b/Lib/test/test_xml_etree_c.py
index 2144d203e1e95..15496fdba2ff8 100644
--- a/Lib/test/test_xml_etree_c.py
+++ b/Lib/test/test_xml_etree_c.py
@@ -8,9 +8,6 @@
cET = import_fresh_module('xml.etree.ElementTree',
fresh=['_elementtree'])
-cET_alias = import_fresh_module('xml.etree.cElementTree',
- fresh=['_elementtree', 'xml.etree'],
- deprecated=True)
@unittest.skipUnless(cET, 'requires _elementtree')
@@ -155,14 +152,6 @@ def test_xmlpullparser_leaks(self):
support.gc_collect()
- at unittest.skipUnless(cET, 'requires _elementtree')
-class TestAliasWorking(unittest.TestCase):
- # Test that the cET alias module is alive
- def test_alias_working(self):
- e = cET_alias.Element('foo')
- self.assertEqual(e.tag, 'foo')
-
-
@unittest.skipUnless(cET, 'requires _elementtree')
@support.cpython_only
class TestAcceleratorImported(unittest.TestCase):
@@ -171,9 +160,6 @@ def test_correct_import_cET(self):
# SubElement is a function so it retains _elementtree as its module.
self.assertEqual(cET.SubElement.__module__, '_elementtree')
- def test_correct_import_cET_alias(self):
- self.assertEqual(cET_alias.SubElement.__module__, '_elementtree')
-
def test_parser_comes_from_C(self):
# The type of methods defined in Python code is types.FunctionType,
# while the type of methods defined inside _elementtree is
@@ -213,7 +199,6 @@ def test_main():
# Run the tests specific to the C implementation
support.run_unittest(
MiscTests,
- TestAliasWorking,
TestAcceleratorImported,
SizeofTest,
)
diff --git a/Lib/xml/etree/cElementTree.py b/Lib/xml/etree/cElementTree.py
deleted file mode 100644
index 368e679189582..0000000000000
--- a/Lib/xml/etree/cElementTree.py
+++ /dev/null
@@ -1,3 +0,0 @@
-# Deprecated alias for xml.etree.ElementTree
-
-from xml.etree.ElementTree import *
More information about the Python-checkins
mailing list