[Python-checkins] bpo-41364: Reduce import overhead of uuid module (GH-21586)

Steve Dower webhook-mailer at python.org
Tue Jul 21 19:16:10 EDT 2020


https://github.com/python/cpython/commit/bf2f76ec0976c09de79c8827764f30e3b6fba776
commit: bf2f76ec0976c09de79c8827764f30e3b6fba776
branch: master
author: Steve Dower <steve.dower at python.org>
committer: GitHub <noreply at github.com>
date: 2020-07-22T00:15:47+01:00
summary:

bpo-41364: Reduce import overhead of uuid module (GH-21586)

files:
A Misc/NEWS.d/next/Library/2020-07-21-21-45-55.bpo-41364.5O-k7A.rst
M Lib/uuid.py

diff --git a/Lib/uuid.py b/Lib/uuid.py
index 9ddce813fc469..5ae0a3e5fa449 100644
--- a/Lib/uuid.py
+++ b/Lib/uuid.py
@@ -45,7 +45,6 @@
 """
 
 import os
-import platform
 import sys
 
 from enum import Enum
@@ -54,10 +53,13 @@
 __author__ = 'Ka-Ping Yee <ping at zesty.ca>'
 
 # The recognized platforms - known behaviors
-_AIX     = platform.system() == 'AIX'
-_DARWIN  = platform.system() == 'Darwin'
-_LINUX   = platform.system() == 'Linux'
-_WINDOWS = platform.system() == 'Windows'
+if sys.platform in ('win32', 'darwin'):
+    _AIX = _LINUX = False
+else:
+    import platform
+    _platform_system = platform.system()
+    _AIX     = _platform_system == 'AIX'
+    _LINUX   = _platform_system == 'Linux'
 
 _MAC_DELIM = b':'
 _MAC_OMITS_LEADING_ZEROES = False
@@ -618,9 +620,9 @@ def _random_getnode():
 #     @unittest.skipUnless(_uuid._ifconfig_getnode in _uuid._GETTERS, ...)
 if _LINUX:
     _OS_GETTERS = [_ip_getnode, _ifconfig_getnode]
-elif _DARWIN:
+elif sys.platform == 'darwin':
     _OS_GETTERS = [_ifconfig_getnode, _arp_getnode, _netstat_getnode]
-elif _WINDOWS:
+elif sys.platform == 'win32':
     # bpo-40201: _windll_getnode will always succeed, so these are not needed
     _OS_GETTERS = []
 elif _AIX:
diff --git a/Misc/NEWS.d/next/Library/2020-07-21-21-45-55.bpo-41364.5O-k7A.rst b/Misc/NEWS.d/next/Library/2020-07-21-21-45-55.bpo-41364.5O-k7A.rst
new file mode 100644
index 0000000000000..f136e892ae5fe
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2020-07-21-21-45-55.bpo-41364.5O-k7A.rst
@@ -0,0 +1 @@
+Reduce import overhead of :mod:`uuid`.



More information about the Python-checkins mailing list