[Python-checkins] bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)

Terry Jan Reedy webhook-mailer at python.org
Mon Feb 10 20:09:06 EST 2020


https://github.com/python/cpython/commit/96ce22706735779cf8cc46eaaa5ac61359364b5a
commit: 96ce22706735779cf8cc46eaaa5ac61359364b5a
branch: master
author: Terry Jan Reedy <tjreedy at udel.edu>
committer: GitHub <noreply at github.com>
date: 2020-02-10T20:08:58-05:00
summary:

bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)

Complete previous patch.

files:
M Lib/idlelib/NEWS.txt
M Lib/idlelib/configdialog.py

diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index d57ba7e6bac90..838120964b2d8 100644
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -3,6 +3,8 @@ Released on 2020-10-05?
 ======================================
 
 
+bpo-39600: Remove duplicate font names from configuration list.
+
 bpo-38792: Close a shell calltip if a :exc:`KeyboardInterrupt`
 or shell restart occurs.  Patch by Zackery Spytz.
 
diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py
index 7b844f00e7736..9d5c2cde04b24 100644
--- a/Lib/idlelib/configdialog.py
+++ b/Lib/idlelib/configdialog.py
@@ -606,10 +606,8 @@ def load_font_cfg(self):
         font_size = configured_font[1]
         font_bold  = configured_font[2]=='bold'
 
-        # Set editor font selection list and font_name.
-        fonts = tkFont.families(self)
-        # remove duplicated names and sort
-        fonts = sorted(set(fonts))
+        # Set sorted no-duplicate editor font selection list and font_name.
+        fonts = sorted(set(tkFont.families(self)))
         for font in fonts:
             self.fontlist.insert(END, font)
         self.font_name.set(font_name)



More information about the Python-checkins mailing list