[Python-checkins] bpo-42773: fix tests not being run on pushes (GH-24004)

miss-islington webhook-mailer at python.org
Wed Dec 30 09:54:11 EST 2020


https://github.com/python/cpython/commit/4ac923f2756f835f512339ee181348cc535ab07f
commit: 4ac923f2756f835f512339ee181348cc535ab07f
branch: master
author: Filipe Laíns <lains at riseup.net>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2020-12-30T06:53:58-08:00
summary:

bpo-42773: fix tests not being run on pushes (GH-24004)



There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains at riseup.net>

files:
M .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1b865a17b09dd..6f05310e6e586 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Check for source changes
         id: check
         run: |
-          if [ -z "GITHUB_BASE_REF" ]; then
+          if [ -z "$GITHUB_BASE_REF" ]; then
             echo '::set-output name=run_tests::true'
           else
             git fetch origin $GITHUB_BASE_REF --depth=1



More information about the Python-checkins mailing list